Remove remnants of AudioChannelManager

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla55
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Bug 1357326 removed the b2g top-level directory. That was the only place setting MOZ_AUDIO_CHANNEL_MANAGER. I meant to remove everything related to MOZ_AUDIO_CHANNEL_MANAGER in bug 1357323 but it turns out I left some parts out. It also turns out that there's not much code with that #ifdef, so I figured I'd just go ahead and remove the whole thing.

One thing that I didn't do, though, but could be done, is that AudioChannelManager was the sole consumer of AudioChannelService::SetDefaultVolumeControlChannel, but since there's actually a SetDefaultVolumeControlChannelInternal that is used by some other code, I figured  I'd leave it there.
Comment hidden (mozreview-request)
Comment on attachment 8859458 [details]
Bug 1357649 - Remove remnants of AudioChannelManager.

https://reviewboard.mozilla.org/r/131492/#review134230
Attachment #8859458 - Flags: review?(bzbarsky) → review+

Comment 3

8 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/e5075b942b6f
Remove remnants of AudioChannelManager. r=bz

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e5075b942b6f
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Setting straight to dev-doc-complete; this has already been archived
Keywords: dev-doc-complete
Blocks: 1369194
No longer blocks: 1369194
(Assignee)

Updated

6 months ago
Depends on: 1373478
You need to log in before you can comment on or make changes to this bug.