Closed
Bug 1357649
Opened 4 years ago
Closed 4 years ago
Remove remnants of AudioChannelManager
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
Bug 1357326 removed the b2g top-level directory. That was the only place setting MOZ_AUDIO_CHANNEL_MANAGER. I meant to remove everything related to MOZ_AUDIO_CHANNEL_MANAGER in bug 1357323 but it turns out I left some parts out. It also turns out that there's not much code with that #ifdef, so I figured I'd just go ahead and remove the whole thing. One thing that I didn't do, though, but could be done, is that AudioChannelManager was the sole consumer of AudioChannelService::SetDefaultVolumeControlChannel, but since there's actually a SetDefaultVolumeControlChannelInternal that is used by some other code, I figured I'd leave it there.
| Comment hidden (mozreview-request) |
|
||
Comment 2•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859458 [details] Bug 1357649 - Remove remnants of AudioChannelManager. https://reviewboard.mozilla.org/r/131492/#review134230
Attachment #8859458 -
Flags: review?(bzbarsky) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/e5075b942b6f Remove remnants of AudioChannelManager. r=bz
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e5075b942b6f
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 5•4 years ago
|
||
Setting straight to dev-doc-complete; this has already been archived
Keywords: dev-doc-complete
|
||
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•