Closed Bug 1357323 Opened 4 years ago Closed 4 years ago

Remove the gonk widget code

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1357323 - Remove support for gonk in the build system.
59 bytes, text/x-review-board-request
gps
: review+
Details
Bug 1357323 - Remove the gonk code that was referenced by the build system.
59 bytes, text/x-review-board-request
gps
: review+
Details 
Per bug 1355752 comment 25, the gonk widget code can go away.
To make things clear, by gonk widget code, I mean the gonk directories in the tree. Code in #ifdef MOZ_WIDGET_GONK sections are covered by other bugs.
Summary: Remove the gonk widget → Remove the gonk widget code
Comment on attachment 8859073 [details]
Bug 1357323 - Remove support for gonk in the build system.

https://reviewboard.mozilla.org/r/131104/#review134032
Attachment #8859073 - Flags: review?(gps) → review+
Comment on attachment 8859074 [details]
Bug 1357323 - Remove the gonk code that was referenced by the build system.

https://reviewboard.mozilla.org/r/131106/#review134034

That's a lot of dead code. And the Try push seems to confirm it is actually dead code.

I'd feel better if some of these things (like the code under ipc/) were reviewed by respective module owners. But dead code is dead code, so I can't imagine others coming to a different conclusion about removing it. Nuke away.
Attachment #8859074 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cd9ef9013062
Remove support for gonk in the build system. r=gps
https://hg.mozilla.org/integration/autoland/rev/38282f1273bb
Remove the gonk code that was referenced by the build system. r=gps
Blocks: 1357649
https://hg.mozilla.org/mozilla-central/rev/cd9ef9013062
https://hg.mozilla.org/mozilla-central/rev/38282f1273bb
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
No longer blocks: 1369194
Blocks: 1373478
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.