1357323 - Remove the gonk widget code

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Per bug 1355752 comment 25, the gonk widget code can go away.

Comment 1

[Mike Hommey [:glandium]]

To make things clear, by gonk widget code, I mean the gonk directories in the tree. Code in #ifdef MOZ_WIDGET_GONK sections are covered by other bugs.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1357323 - Remove support for gonk in the build system.

Everything depending on the widget being gonk can go away, as well as
everything depending on MOZ_AUDIO_CHANNEL_MANAGER, which was only
defined on gonk builds under b2g/ (which goes away in bug 1357326).

Review commit: https://reviewboard.mozilla.org/r/131104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131104/

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1357323 - Remove the gonk code that was referenced by the build system.

Review commit: https://reviewboard.mozilla.org/r/131106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131106/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8859073 [details]
Bug 1357323 - Remove support for gonk in the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131104/diff/1-2/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8859074 [details]
Bug 1357323 - Remove the gonk code that was referenced by the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131106/diff/1-2/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8859073 [details]
Bug 1357323 - Remove support for gonk in the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131104/diff/2-3/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8859074 [details]
Bug 1357323 - Remove the gonk code that was referenced by the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131106/diff/2-3/

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8859073 [details]
Bug 1357323 - Remove support for gonk in the build system.

https://reviewboard.mozilla.org/r/131104/#review134032

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8859074 [details]
Bug 1357323 - Remove the gonk code that was referenced by the build system.

https://reviewboard.mozilla.org/r/131106/#review134034

That's a lot of dead code. And the Try push seems to confirm it is actually dead code.

I'd feel better if some of these things (like the code under ipc/) were reviewed by respective module owners. But dead code is dead code, so I can't imagine others coming to a different conclusion about removing it. Nuke away.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd9ef9013062
Remove support for gonk in the build system. r=gps
https://hg.mozilla.org/integration/autoland/rev/38282f1273bb
Remove the gonk code that was referenced by the build system. r=gps

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cd9ef9013062
https://hg.mozilla.org/mozilla-central/rev/38282f1273bb