Closed
Bug 1357323
Opened 5 years ago
Closed 5 years ago
Remove the gonk widget code
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Per bug 1355752 comment 25, the gonk widget code can go away.
Assignee | ||
Comment 1•5 years ago
|
||
To make things clear, by gonk widget code, I mean the gonk directories in the tree. Code in #ifdef MOZ_WIDGET_GONK sections are covered by other bugs.
Summary: Remove the gonk widget → Remove the gonk widget code
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•5 years ago
|
||
mozreview-review |
Comment on attachment 8859073 [details] Bug 1357323 - Remove support for gonk in the build system. https://reviewboard.mozilla.org/r/131104/#review134032
Attachment #8859073 -
Flags: review?(gps) → review+
Comment 9•5 years ago
|
||
mozreview-review |
Comment on attachment 8859074 [details] Bug 1357323 - Remove the gonk code that was referenced by the build system. https://reviewboard.mozilla.org/r/131106/#review134034 That's a lot of dead code. And the Try push seems to confirm it is actually dead code. I'd feel better if some of these things (like the code under ipc/) were reviewed by respective module owners. But dead code is dead code, so I can't imagine others coming to a different conclusion about removing it. Nuke away.
Attachment #8859074 -
Flags: review?(gps) → review+
Comment 10•5 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/cd9ef9013062 Remove support for gonk in the build system. r=gps https://hg.mozilla.org/integration/autoland/rev/38282f1273bb Remove the gonk code that was referenced by the build system. r=gps
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cd9ef9013062 https://hg.mozilla.org/mozilla-central/rev/38282f1273bb
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•