Update cubeb from upstream to 6e52314

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: cubeb
P1
normal
Rank:
15
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: achronop, Assigned: achronop)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago
Pick commits:

6e52314 Alex Chronopoulos       audiounit: Add unique id in aggregate device name and UID. (#280)
36b10ff Dan Glastonbury Rename g_log_... to g_cubeb_log_...
fd66f15 Chun-Min Chang  Remove .get() for unique_ptr
8939c0d Chun-Min Chang  Replace RAII wrapper with unique_ptr
935208c Lioncash        cubeb_wasapi: Correct duplicate bitwise OR entry in wasapi_enumerate_devices()
c02db67 Lioncash        cubeb_sndio: Fix leak in sndio_stream_init() failure case
72a9685 Michael Maltese tests: Remove code preferring floats on Win32
2bb3e25 Michael Maltese wasapi: Implement S16NE-format streams
9679dce Michael Maltese Extract wasapi invalid format message to cubeb_stream_init
727a7a4 Michael Maltese wasapi: Add and use class mixing_wrapper
eacf836 Michael Maltese wasapi: Use auto_array_wrapper for linear input buffer
38d7491 Michael Maltese audiounit: extract auto_array_wrapper to cubeb_utils
ebf8674 Matthew Gregan  opensl: Rename __system_property_get wrapper to avoid build issues. (#279)
2c004d8 ligfx   audiounit: remove draining logic from input_callback (#272)
b6e2332 Chun-Min Chang  Add a deadlock test on OSX (#266)
7c65020 Chun-Min Chang  Rename mixer stuff
d17eee0 Chun-Min Chang  Use auto-for-loop in test_mixer.cpp and fix typo
6e3a6ae Chun-Min Chang  Use plain std::unique_ptr and new instead of custom deleter
2b1132b Chun-Min Chang  Using gtest style's error message in cubeb (#274)
61aaac2 Chun-Min Chang  assert everywhere rather than returning a result
7d68ec2 Chun-Min Chang  Replace cubeb_cleaner and cubeb_stream_cleaner by unique_ptr
2612c20 Chun-Min Chang  Using RAII helpers for cubeb context and stream but leaving test_sanity for explicit flow control
(Assignee)

Updated

a month ago
Blocks: 1355306
(Assignee)

Comment 1

a month ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=94aa17ef9a8b
(Assignee)

Comment 2

a month ago
Created attachment 8859590 [details] [diff] [review]
Bug 1357683 - Update cubeb from upstream to 6e52314
Attachment #8859590 - Flags: review?(padenot)
(Assignee)

Updated

a month ago
Assignee: nobody → achronop
Rank: 15
Priority: -- → P1
Attachment #8859590 - Flags: review?(padenot) → review+
(Assignee)

Comment 3

a month ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/819e873822636fb84c3d6ee8f933998e1892edf5
Bug 1357683 - Update cubeb from upstream to 6e52314. r=padenot
Blocks: 1334963
https://hg.mozilla.org/mozilla-central/rev/819e87382263
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1358756
You need to log in before you can comment on or make changes to this bug.