Closed
Bug 1357683
Opened 8 years ago
Closed 8 years ago
Update cubeb from upstream to 6e52314
Categories
(Core :: Audio/Video: cubeb, defect, P1)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: achronop, Assigned: achronop)
References
Details
Attachments
(1 file)
90.05 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
Pick commits:
6e52314 Alex Chronopoulos audiounit: Add unique id in aggregate device name and UID. (#280)
36b10ff Dan Glastonbury Rename g_log_... to g_cubeb_log_...
fd66f15 Chun-Min Chang Remove .get() for unique_ptr
8939c0d Chun-Min Chang Replace RAII wrapper with unique_ptr
935208c Lioncash cubeb_wasapi: Correct duplicate bitwise OR entry in wasapi_enumerate_devices()
c02db67 Lioncash cubeb_sndio: Fix leak in sndio_stream_init() failure case
72a9685 Michael Maltese tests: Remove code preferring floats on Win32
2bb3e25 Michael Maltese wasapi: Implement S16NE-format streams
9679dce Michael Maltese Extract wasapi invalid format message to cubeb_stream_init
727a7a4 Michael Maltese wasapi: Add and use class mixing_wrapper
eacf836 Michael Maltese wasapi: Use auto_array_wrapper for linear input buffer
38d7491 Michael Maltese audiounit: extract auto_array_wrapper to cubeb_utils
ebf8674 Matthew Gregan opensl: Rename __system_property_get wrapper to avoid build issues. (#279)
2c004d8 ligfx audiounit: remove draining logic from input_callback (#272)
b6e2332 Chun-Min Chang Add a deadlock test on OSX (#266)
7c65020 Chun-Min Chang Rename mixer stuff
d17eee0 Chun-Min Chang Use auto-for-loop in test_mixer.cpp and fix typo
6e3a6ae Chun-Min Chang Use plain std::unique_ptr and new instead of custom deleter
2b1132b Chun-Min Chang Using gtest style's error message in cubeb (#274)
61aaac2 Chun-Min Chang assert everywhere rather than returning a result
7d68ec2 Chun-Min Chang Replace cubeb_cleaner and cubeb_stream_cleaner by unique_ptr
2612c20 Chun-Min Chang Using RAII helpers for cubeb context and stream but leaving test_sanity for explicit flow control
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8859590 -
Flags: review?(padenot)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → achronop
Rank: 15
Priority: -- → P1
Updated•8 years ago
|
Attachment #8859590 -
Flags: review?(padenot) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/819e873822636fb84c3d6ee8f933998e1892edf5
Bug 1357683 - Update cubeb from upstream to 6e52314. r=padenot
Updated•8 years ago
|
Blocks: Fennec-ARM64
Comment 4•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
See bug 1388437 comment 24 pointing to this update as a cause of a very common crash.
Comment 6•7 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #5)
> See bug 1388437 comment 24 pointing to this update as a cause of a very
> common crash.
This is likely bug 1362764 (linked from this bug), which was uplifted (via bug 1386957) to 56 but not 55.
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•