1355306 - getUserMedia doesn't work in more than one tab at a time now

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

getUserMedia doesn't work in more than one tab at a time now. Audio is the problem.

STRs:
  1. Open http://jsfiddle.net/jib1/cfzznzsy/ and share mic.
  2. Open new tab and repeat.

Expected result:
  Audio element visibly playing in both tabs.

Actual result:
  Audio element visibly playing in first tab only, not in second tab.

Regression range:
  23:42.48 INFO: Last good revision: c807c80d954a7761c3aae2036d3a1c4d3b55ba51
  23:42.48 INFO: First bad revision: 1fbff6defb481238929060e04b330e5870b013be
  23:42.48 INFO: Pushlog:
  https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c807c80d954a7761c3aae2036d3a1c4d3b55ba51&tochange=1fbff6defb481238929060e04b330e5870b013be

If audio+video is requested, video fails to appear in the second tab as well: http://jsfiddle.net/jib1/srn9db4h/

This may be the same as bug 1353947 but the STRs are way simpler, so I filed anew.

This breaks simple things like joining appr.tc from two tabs.

Comment 1

[Alex Chronopoulos [:achronop]]

The first cubeb stream initialized successfully but the 2nd fails during the create of aggregate device:

[Unnamed thread 0x17bda0b20]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb.c:539: DeviceID: "AppleHDAEngineInput:1B,0,1,0:1" (PREFERRED)
	Name:	"External Microphone"
	Group:	"AppleHDAEngineInput:1B,0,1,0:1"
	Vendor:	"Apple Inc."
	Type:	input
	State:	enabled
	Max
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2227: (0x127f3f780) Opening output side: rate 44100, channels 2, format 2, latency in frames 512.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2250: (0x127f3f780) Output device sampling rate: 44100.00
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2050: (0x127f3f780) No need to update output buffer size already 512 frames
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2297: (0x127f3f780) Output audiounit init successfully.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2553: (0x127f3f780) Cubeb stream init successful.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2634: Cubeb stream (0x127f3f780) started successfully.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2662: Cubeb stream (0x127f3f780) stopped successfully.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2605: Cubeb stream (0x127f3f780) destroyed successful.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:1519: AudioObjectGetPropertyData/kAudioPlugInCreateAggregateDevice, rv=1852797029
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:1696: (0x127f3f780) Failed to create blank aggregate device
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2315: (0x127f3f780) Create aggregate devices failed.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2548: (0x127f3f780) Could not setup the audiounit stream.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2605: Cubeb stream (0x127f3f780) destroyed successful.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:1519: AudioObjectGetPropertyData/kAudioPlugInCreateAggregateDevice, rv=1852797029
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:1696: (0x127f3f780) Failed to create blank aggregate device
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2315: (0x127f3f780) Create aggregate devices failed.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2548: (0x127f3f780) Could not setup the audiounit stream.
[CubebOperation #1]: E/cubeb /Users/achronopoulos/repos/mozilla/firefox/media/libcubeb/src/cubeb_audiounit.cpp:2605: Cubeb stream (0x127f3f780) destroyed successful.


AudioObjectGetPropertyData/kAudioPlugInCreateAggregateDevice, rv=1852797029 (nope)

I will take a closer look.

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: audiounit: Add unique id in aggregate device name and UID.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8857475 [details] [review]
audiounit: Add unique id in aggregate device name and UID.

Looks like Paul reviewed this.

Comment 4

[Paul Adenot (:padenot)]

Comment on attachment 8857475 [details] [review]
audiounit: Add unique id in aggregate device name and UID.

I reviewed this on github (https://github.com/kinetiknz/cubeb/pull/280), and this is going in shortly (see dependent bugs).

Comment 5

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 6

[Alex Chronopoulos [:achronop]]

Fixed by 1357683