Closed
Bug 1357919
Opened 9 years ago
Closed 9 years ago
Arabic text should be right aligned
Categories
(Webtools Graveyard :: Pontoon, enhancement, P2)
Webtools Graveyard
Pontoon
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: khaled, Assigned: mathjazz, Mentored)
Details
Entries in HISTORY, MACHINERY and LOCALES should be right aligned for Arabic and other right-to-left scripts.
| Assignee | ||
Comment 1•9 years ago
|
||
Does this apply to all occurences of RTL scripts?
Which also includes:
- translations in the string list
- latest activity tooltip (e.g. on https://pontoon.mozilla.org/ar/)
- profile timeline (e.g. on https://pontoon.mozilla.org/contributors/JAENo8874-H5lpgz_Igr7Xt3tvA/)
Mentor: m
Priority: -- → P2
| Reporter | ||
Comment 2•9 years ago
|
||
In general, whenever left-to-right text is left aligned, right-to-left text should be right aligned and vice versa, unless there is really a good reason for doing otherwise (usually there isn’t). So I think the answer is yes. For the profile timeline that quote mark might need to be on the right side and be mirrored as well.
| Reporter | ||
Comment 3•9 years ago
|
||
Re-quote mark, it should be the closing mark (i.e. ”) not simply mirrored.
| Reporter | ||
Comment 4•9 years ago
|
||
Bug 1190566 applies here as well; text direction should be set to rtl not just right alignment.
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → m
| Assignee | ||
Comment 5•9 years ago
|
||
Khaled, I've deployed several fixes to stage:
- bug 1357919: Right-align RTL text (this bug)
- bug 1190566: Use actual direction instead of auto in dir attributes
- bug 1357945: Use italic only for scripts supported in Open Sans
- Sort suggestions from other locales (Locale tab) alphabetically by locale name
You can have a look here:
https://mozilla-pontoon-staging.herokuapp.com/ar/pontoon-intro/all-resources/
Could you please let me know your thoughts about this?
Flags: needinfo?(khaledhosny)
| Reporter | ||
Comment 6•9 years ago
|
||
All looks good now, much better! Thanks.
Flags: needinfo?(khaledhosny)
Comment 7•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/pontoon
https://github.com/mozilla/pontoon/commit/a2bcd395eac8bcd0e4c82766f37184baf48c7da0
Fix bug 1357919: Right-align RTL text
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•