1358010 - Permaorange assertion failure and crash in test_vrDisplay_getFrameData.html when Gecko 55 merges to beta on 2017-06-12

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=92882705&repo=try&lineNumber=5316 (you should be able to reproduce that locally by just changing /config/milestone.txt from 55a1 to 55).

[Tracking Requested - why for this release]:

Merge bustage, closed tree, delayed b1.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

Review commit: https://reviewboard.mozilla.org/r/131976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131976/

Comment 2

[Daosheng Mu[:daoshengmu]]

This is because WebVR API is not enabled at Release and Beta. For Windows, we will let it enable by default. But, the patch from Bug 1343368 is behind my patch of the tree. Therefore, I have to skip them at Release and Beta.

Comment 3

[:kip (Kearwood Gilbert)]

When 55 merges to beta, WebVR is enabled by default (enabling patch already landed in Mozilla-central).  It is enabled only for Windows platforms and will crash if enabled on Mac or Linux currently.

See Bug 1310655 to follow the Linux support, which will be enabled post-55.

The issue appears to be that the tests are crashing on Linux when they hit assertions due to only DirectX VR rendering being implemented.

The solution should be to disable the tests for all but Windows, but still allow hem to run in release.

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8859922 [details]
Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

https://reviewboard.mozilla.org/r/131976/#review134748

::: dom/vr/test/mochitest.ini:9
(Diff revision 1)
>    requestPresent.js
>    runVRTest.js
>    WebVRHelpers.js
>  
>  [test_vrDisplay_exitPresent.html]
> +skip-if = release_or_beta # WebVR is not enabled at release & beta

Rather than disabling the tests in release, we should be disabling them for non-windows platforms until Bug 1310655 lands.

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8859922 [details]
Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

https://reviewboard.mozilla.org/r/131976/#review134748

thanks for jumping into this issue so quickly!  Please see my comment on the bug, as we will want to keep the tests enabled for release in 55.  Just need to change the condition to only run the tests in Windows.

Comment 6

[Daosheng Mu[:daoshengmu]]

I think the root cause is not due to we didn't implement non-D3D VR rendering. VRPuppetDevice works well at Nightly version on Linux/Mac platforms.

This is because "dom.vr.enabled" is `Once` at gfxPrefs, https://dxr.mozilla.org/mozilla-central/rev/20dff607fb88ee69135a280bbb7f32df75a86237/gfx/thebes/gfxPrefs.h#349, and we only allow Windows OS or non-release version to enable it. Although I tried to change it to be true at runtime (https://dxr.mozilla.org/mozilla-central/rev/20dff607fb88ee69135a280bbb7f32df75a86237/dom/vr/test/runVRTest.js#2), it is not happened because it's flag is `Once`.

So, I think if we decide to keep `dom.vr.enabled` to be `Once`. I should remove it from SpecialPower and add skip-if = (os != "win" && release_or_beta) at the mochitest.ini

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8859922 [details]
Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131976/diff/1-2/

Comment 8

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8859922 [details]
Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131976/diff/2-3/

Comment 9

[Marcia Knous [:marcia]]

Tracking 55+ for this permaorange, especially to avoid delays in B1.

Comment 10

[:kip (Kearwood Gilbert)]

Comment on attachment 8859922 [details]
Bug 1358010 - Skip vr mochitests when running on release and non-Windows platforms;

https://reviewboard.mozilla.org/r/131976/#review135054

Thanks Daosheng, I just saw your comment about the order of the patches.

This looks okay to me.

Please follow up with a new bug to enable the tests for release and linux configurations at the right time.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe865149e0e
Skip vr mochitests when running on release and non-Windows platforms; r=kip

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afe865149e0e