1358080 - remove dependency on devtools webconsole-utils from InsecurePasswordUtils.jsm

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

DevTools are moving away from mozilla central and dependencies on devtools code need to be removed.

toolkit/components/passwordmgr/InsecurePasswordUtils.jsm relies on a devtools webconsole utils file to retrieve the currentInnerWindowID from a provided window object. I don't this code is worth extracting from devtools and should simply be inlined in InsecurePasswordUtils.jsm

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1358080 - add logic to get inner window id to InsecurePasswordUtils.jsm;

InsecurePasswordUtils.jsm used to rely on a devtools util to get the innerWindowId
of window objects. As devtools are moving out of mozilla-central, this code needs
to be extracted and the dependency should be removed.

Review commit: https://reviewboard.mozilla.org/r/132008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132008/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8859972 [details]
Bug 1358080 - add logic to get inner window id to InsecurePasswordUtils.jsm;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132008/diff/1-2/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8859972 [details]
Bug 1358080 - add logic to get inner window id to InsecurePasswordUtils.jsm;

https://reviewboard.mozilla.org/r/132008/#review137416

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review! 

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98a60b3f0c3a5cf58830e2cdc797c56ae7b8444e

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5fbea7e93d4
add logic to get inner window id to InsecurePasswordUtils.jsm;r=MattN

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f5fbea7e93d4