1358089 - [RTL] broken UI layout after last update

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Tomer Cohen :tomer]

Please note that I can't reproduce this on my devices, I am just passing user feedback. 

A user provided feedback from our community page on Facebook about regression since last update (Fennec 53):

The URL bar layout is misaligned once he click on it. See attached screenshot.


Device: OnePlus 3T, Android 7.1.1, official stock ROM, Hebrew UI.
Browser: Firefox 53 (Release channel), switching languages between Hebrew and English has no effect.

Bug is visible only when Android system UI is set the Hebrew. Bug does not reproduce on English UI. This bug is a regression since previous version, as this is the first with RTL UI enabled.

Comment 1

[Tomer Cohen :tomer]

Attachment: Screenshot

Comment 2

[Max Liu [:maliu]]

Attachment: Bug 1358089 - [RTL] Separate xml drawable into v17 folder,

Review commit: https://reviewboard.mozilla.org/r/133260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133260/

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:
This is a regression that impacts RTL users.
53 is the release we claim the RTL support so I'm nominating this fix to be uplifted.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Leaving this for ahunt to review.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

It's misaligned but maybe still usable. 
Please request uplift to mozilla-release once the patch land on m-c and we can verify the fix. 
I'm not sure this will make the 53.0.2 dot release, which I'm hoping to build today.

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8861300 [details]
Bug 1358089 - [RTL] Separate xml drawable into v17 folder,

https://reviewboard.mozilla.org/r/133260/#review136586

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f259b3ca035
[RTL] Separate xml drawable into v17 folder, r=ahunt

Comment 8

[Max Liu [:maliu]]

Comment on attachment 8861300 [details]
Bug 1358089 - [RTL] Separate xml drawable into v17 folder,

Approval Request Comment
[Feature/Bug causing the regression]: RTL Bug 1350661
[User impact if declined]: Fennec UI in LTR(English) with system locale in RTL(Hebrew) will see abnormal UI when editing in UrlBar 
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Set android system locale to RTL(Hebrew) and specify fennec locale to LTR(English), click on Urlbar to edit and observe.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Manually verified on multiple Android version.
[String changes made/needed]: No

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f259b3ca035

Comment 10

[Gerry Chang [:gchang]]

Hi Ioana, 
could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 11

[Gerry Chang [:gchang]]

Hi Mihai,
Can you help verify this?

Comment 12

[Itiel]

According to the user that reported this in the first place on our community page on Facebook, the issue is now fixed on latest Nightly.

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8861300 [details]
Bug 1358089 - [RTL] Separate xml drawable into v17 folder,

Fix an RTL regression. Beta54+. Should be in 54 beta 4.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dcdffee8cfe9

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8861300 [details]
Bug 1358089 - [RTL] Separate xml drawable into v17 folder,

Verified fix, let's uplift it to m-r for the 53.0.2 dot release.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a027d0740f0d

Comment 17

[Bogdan Surd, QA [:bsurd, NI]]

Device: Nexus 6 (Android 7.0)
Build 53.0.2

Comment 19

[Ioana Chiorean]

As this was verified by Bogdan, will take out the NI