1358104 - createElementNS() should now throw only InvalidCharacterError, not NamespaceError

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://github.com/whatwg/dom/issues/319
https://github.com/w3c/web-platform-tests/issues/5161
https://github.com/whatwg/dom/issues/423

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Bug 1358104 - Only throw InvalidCharacterError for bad XML id's, not NamespaceError

Discussion at <https://github.com/whatwg/dom/issues/319>.  In short, the
specification used to say to throw sometimes InvalidCharacterError and
sometimes NamespaceError, but browsers disagreed on which to throw in
corner cases, and everyone agreed it wasn't worth the effort to spec the
distinction, so we just changed it to InvalidCharacterError across the
board.

The test changes are already upstream.

Review commit: https://reviewboard.mozilla.org/r/132074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132074/

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8860049 [details]
Bug 1358104 - Only throw InvalidCharacterError for bad XML id's, not NamespaceError

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132074/diff/1-2/

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8860049 [details]
Bug 1358104 - Only throw InvalidCharacterError for bad XML id's, not NamespaceError

https://reviewboard.mozilla.org/r/132074/#review137688

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b57cea736265
Only throw InvalidCharacterError for bad XML id's, not NamespaceError r=baku

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b57cea736265