135828 - Email-address-changing UI requires polish

Status: NEW

(Bugzilla :: User Interface, enhancement, P3)

Description

[John Vandenberg]

The user interface which tracks the email change process is in need of polish.

If a user submits a new email address in userprefs.cgi, the UI informs the user
that 'The changes to your account settings have been saved.' as well as 'An
email has been sent to both old and new email addresses to confirm the change of
email address.'  As the user has only submitted a change request, the former
message is misleading.

Comment 1

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 2

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 3

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 4

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 5

[Simon Green]

Attachment: v1 patch

Comment 6

[:glob ✱]

Comment on attachment 8585247 [details] [diff] [review]
v1 patch

Review of attachment 8585247 [details] [diff] [review]:
-----------------------------------------------------------------

if you change your email and your real name, the "changes have been saved" message is not displayed.

Comment 7

[Simon Green]

Attachment: bug135828-v2.patch

Comment 8

[:glob ✱]

Comment on attachment 8588386 [details] [diff] [review]
bug135828-v2.patch

Review of attachment 8588386 [details] [diff] [review]:
-----------------------------------------------------------------

this reintroduces the original issue, but with "(if any)" text.
that your changes have been updated is lost in the lengthy "in order to confirm your request.." text, and i think this patch leaves us in a worse position than we currently have.

how this should work is:
- if you make any changes to non-email fields, display the "your changes have been saved.." message
- if you change you email address, display the the "in order to confirm your request.." message