1358353 - stylo: mismatches computed values or specified values in getKeyframes()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

For example, 

  @keyframes anim {
    from { color: red }
    to { color: green }
  }

on current gecko, getKeyframes() returns rgb(255, 0, 0) and rgb(0, 128, 0) respectively. Whereas on stylo getKeyframes() returns 'red' and 'green'.

On the other hand,

  element.animate({ color: ['red', 'green'] }, 1000);

on current gecko, getKeyframes() returns 'red' and 'green'.

IIRC, current gecko returns computed values for css animation because of css variable(?).

file_keyframeeffect-getkeyframes.html has a bunch of test cases that rely on current gecko behavior,  but all test cases in the file does not aim to check computed values. So I'd suggest to replace keyword color with rgb() colors in the test file.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I and Brian discussed about early this week and we agreed that we should change keyword color value to rgb color in the test case.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b410fa66ff8e1ff249fa4cd0a164ad90eae0f7e1

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1358353 - Use rgb value instead of keyword colors.

Review commit: https://reviewboard.mozilla.org/r/134598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134598/

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8862732 [details]
Bug 1358353 - Use rgb value instead of keyword colors.

https://reviewboard.mozilla.org/r/134598/#review137586

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42e64e0c808f
Use rgb value instead of keyword colors. r=boris

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42e64e0c808f