1358391 - 2.24ms uninterruptible reflow at handleEvent@chrome://browser/content/tabbrowser.xml:6224:19

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, enhancement, P4)

Description

[Hazel Ward]

Here's the stack:

handleEvent@chrome://browser/content/tabbrowser.xml:6224:19
EventListener.handleEvent*tabbrowser-tabs_XBL_Constructor@chrome://browser/content/tabbrowser.xml:5664:11

Comment 1

[Florian Quèze [:florian]]

I guess this is when resizing the browser window, with the this.mTabstrip.boxObject.width at http://searchfox.org/mozilla-central/rev/7aa21f3b531ddee90a353215bd86e97d6974e25b/browser/base/content/tabbrowser.xml#6223

I wonder if we could avoid this (or reduce its cost) by using requestAnimationFrame.

Comment 2

[Brian Carpenter [:geeknik]]

Another stack:

handleEvent@chrome://browser/content/tabbrowser.xml:6265:19
rect@chrome://browser/content/browser-tabsintitlebar.js:106:23
_update@chrome://browser/content/browser-tabsintitlebar.js:157:28
updateAppearance@chrome://browser/content/browser-tabsintitlebar.js:65:5
toggle@chrome://browser/content/browser-fullScreenAndPointerLock.js:333:7
handleEvent@chrome://browser/content/browser-fullScreenAndPointerLock.js:349:9
EventListener.handleEvent*init@chrome://browser/content/browser-fullScreenAndPointerLock.js:255:5
_delayedStartup@chrome://browser/content/browser.js:1506:5
EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1239:5
onload@chrome://browser/content/browser.xul:1:1

Comment 3

[Florian Quèze [:florian]]

I'm not convinced the stack in comment 2 is the same bug. Comment 0 was when resizing the browser window. Comment 2 seems to be when entering or leaving fullscreen. The code around http://searchfox.org/mozilla-central/rev/f225dbcb15ca2e38f7d434a9278a41d2340e7cf3/browser/base/content/browser-tabsintitlebar.js#156 does several calls that could trigger sync reflows.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This reflow no longer exists, since bug 1414252 landed.