1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Dão Gottwald [:dao]]

This check:

              var width = this.mTabstrip.boxObject.width;
              if (width != this.mTabstripWidth) {

... is pretty much guaranteed to always pass, because when the window resizes the tab strip must grow or shrink accordingly.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

Review commit: https://reviewboard.mozilla.org/r/196238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196238/

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 8925001 [details]
Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

https://reviewboard.mozilla.org/r/196238/#review201468

Would be interested to know why the case would not be triggered now but would before, but doesnt look to have a negative effect and nice to get rid of some code

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bedc52fb5267
Remove dysfunctional performance optimization in tabbrowser's resize handler. r=daleharvey

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser-chrome's browser/base/content/test/performance/browser_windowopen_reflows.js, at least on OS X:

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bedc52fb5267646d5689e4450a455daf66e8e2ac&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=141982038&repo=autoland

09:36:12     INFO - Buffered messages finished
09:36:12     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_reflows.js | Unused expected reflow: [
09:36:12     INFO - 	"handleEvent@chrome://browser/content/tabbrowser.xml",
09:36:12     INFO - 	"inferFromText@chrome://browser/content/browser.js",
09:36:12     INFO - 	"handleEvent@chrome://browser/content/browser.js"
09:36:12     INFO - ]

After you updated the whitelist, please check if the en-US failures also show up on the backout or disappeared earlier and are not correlated to this patch. Thank you.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/194be9a406b3
Backed out changeset bedc52fb5267 for failing browser-chrome's browser/base/content/test/performance/browser_windowopen_reflows.js, at least on OS X. r=backout on a CLOSED TREE

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8925001 [details]
Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196238/diff/1-2/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8925001 [details]
Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196238/diff/2-3/

Comment 8

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a761ef19b8ed54e6c7f51061b64f6b928a86662b

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dao, with that change there were also problems with the test `test_tabbar_session_restore_button.py TestTabbarSessionRestoreButton.test_window_resizing`. Can you please also check bug 1384875 comment 14? Thanks.

Comment 10

[Dão Gottwald [:dao]]

Comment 4 already mentioned this. I don't see anything particular in bug 1384875 comment 14 to respond to.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just saying because your last try build didn't run those tests.

Comment 12

[Dão Gottwald [:dao]]

Yeah, I'm still working on the patch.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8925001 [details]
Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196238/diff/3-4/

Comment 14

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c796ead130a236d95fa4a874d97324e905d6eafa

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56e6677ef5a8
Remove dysfunctional performance optimization in tabbrowser's resize handler. r=daleharvey

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/56e6677ef5a8