Closed Bug 1414252 Opened 2 years ago Closed 2 years ago

Remove dysfunctional performance optimization in tabbrowser's resize handler

Categories

(Firefox :: Tabbed Browser, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

This check:

              var width = this.mTabstrip.boxObject.width;
              if (width != this.mTabstripWidth) {

... is pretty much guaranteed to always pass, because when the window resizes the tab strip must grow or shrink accordingly.
Comment on attachment 8925001 [details]
Bug 1414252 - Remove dysfunctional performance optimization in tabbrowser's resize handler.

https://reviewboard.mozilla.org/r/196238/#review201468

Would be interested to know why the case would not be triggered now but would before, but doesnt look to have a negative effect and nice to get rid of some code
Attachment #8925001 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bedc52fb5267
Remove dysfunctional performance optimization in tabbrowser's resize handler. r=daleharvey
Backed out for failing browser-chrome's browser/base/content/test/performance/browser_windowopen_reflows.js, at least on OS X:

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bedc52fb5267646d5689e4450a455daf66e8e2ac&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=141982038&repo=autoland

09:36:12     INFO - Buffered messages finished
09:36:12     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_reflows.js | Unused expected reflow: [
09:36:12     INFO - 	"handleEvent@chrome://browser/content/tabbrowser.xml",
09:36:12     INFO - 	"inferFromText@chrome://browser/content/browser.js",
09:36:12     INFO - 	"handleEvent@chrome://browser/content/browser.js"
09:36:12     INFO - ]

After you updated the whitelist, please check if the en-US failures also show up on the backout or disappeared earlier and are not correlated to this patch. Thank you.
Flags: needinfo?(dao+bmo)
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/194be9a406b3
Backed out changeset bedc52fb5267 for failing browser-chrome's browser/base/content/test/performance/browser_windowopen_reflows.js, at least on OS X. r=backout on a CLOSED TREE
Flags: needinfo?(dao+bmo)
See Also: → 1384875
Dao, with that change there were also problems with the test `test_tabbar_session_restore_button.py TestTabbarSessionRestoreButton.test_window_resizing`. Can you please also check bug 1384875 comment 14? Thanks.
Flags: needinfo?(dao+bmo)
Comment 4 already mentioned this. I don't see anything particular in bug 1384875 comment 14 to respond to.
Flags: needinfo?(dao+bmo)
Just saying because your last try build didn't run those tests.
Yeah, I'm still working on the patch.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56e6677ef5a8
Remove dysfunctional performance optimization in tabbrowser's resize handler. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/56e6677ef5a8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.