1358562 - remove non-e10s linux64-stylo talos jobs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task, P5)

Description

[Kim Moir [:kmoir] ET]

From bug 1355023 

Kim, it looks like we currently run Talos (d g3 g4) for Stylo with both e10s and non-e10s on m-c. We don't need to run Talos on non-e10s. We'd like to replace that Stylo non-e10s run with an "e10s + Stylo sequential mode" run, like bug 1356122.

Can you please make this Talos change after you fix bug 1356122?

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1358562.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b27c50a2047bf0599847db352cf864ee7d15a7f3

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1358562.patch

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug1358562-2.patch

Comment 4

[Kim Moir [:kmoir] ET]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b7f0ac25e746d0079e54953bfb2b2d58fd4bfc5

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1358562-3.patch

Try run with linux stylo showing only e10s talos jobs running

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b441b5f827482313d6837e91e478317585320958

Ran linux64 try run to ensure that 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fe02264f740f225aa095dad619da60c111a581b
both e10s and non-e10s tests run for that platform

diff of ./mach taskgraph target -p ~/Downloads/parameters-m-c.yml with this patch applied
< test-linux64-stylo/opt-talos-chrome
1268d1266
< test-linux64-stylo/opt-talos-dromaeojs
1270d1267
< test-linux64-stylo/opt-talos-g1
1272d1268
< test-linux64-stylo/opt-talos-g2
1274d1269
< test-linux64-stylo/opt-talos-g3
1276d1270
< test-linux64-stylo/opt-talos-g4
1278d1271
< test-linux64-stylo/opt-talos-other
1280d1272
< test-linux64-stylo/opt-talos-perf-reftest
1282d1273
< test-linux64-stylo/opt-talos-svgr
1284d1274
< test-linux64-stylo/opt-talos-tp5o

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf1daf14fa7
remove non-e10s linux64-stylo talos jobs r=aki DONTBUILD

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/522b93c51537
revert Bug 1358562 - remove non-e10s linux64-stylo talos jobs r=aki

Comment 8

[Kim Moir [:kmoir] ET]

This didn't work because I tested in m-c.  However, when I landed it on m-i the decision graph failed.  Investigating.

Comment 9

[Kim Moir [:kmoir] ET]

Attachment: bug1358562-4.patch

This should fix the bustage

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77584adad526
remove non-e10s linux64-stylo talos jobs r=aki

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c9c06059b38
remove non-e10s linux64-stylo talos jobs r=aki DONTBUILD

Comment 12

[Kim Moir [:kmoir] ET]

hmm, so it seems like this patch landed on inbound but hasn't been uploaded to m-c yet, this is why non-e10s talos are still running on m-c.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/77584adad526
https://hg.mozilla.org/mozilla-central/rev/6c9c06059b38

Comment 14

[Kartikaya Gupta (email:[e-mail])]

This patch appears to have broken the decision task on the graphics branch [1], error message is "Exception: No project matching 'graphics' nor 'default' found while determining item e10s in talos-svgr". Presumably the linux64-stylo/opt branch should have a "default" branch in the by-project breakdown?

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=98053771&repo=graphics&lineNumber=616

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/361024338c3a
Follow-up to fix bustage on the graphics branch. r=bustage

Comment 16

[Kartikaya Gupta (email:[e-mail])]

I just went ahead and landed a fix on the graphics branch to unbreak it. Kim, could you please take a quick look to make sure this is fine? ^

I verified that this works locally using ./mach taskgraph target-graph -p graphics.yml

Comment 17

[Kim Moir [:kmoir] ET]

lgtm

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/361024338c3a