Closed
Bug 1358666
Opened 7 years ago
Closed 7 years ago
(intersection-observer) Import and enable web-platform tests
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: tschneider, Assigned: tschneider)
References
Details
Attachments
(1 file, 6 obsolete files)
|
79.04 KB,
patch
|
bugs
:
review+
|
Details | Diff | Splinter Review |
Lets get web-platform tests for the Intersection Observer API to work and enable them for better test coverage.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8860564 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Blocks: intersection-observer-impl
|
|
Assignee | |
Comment 3•7 years ago
|
||
All tests (with patches from dependencies) except of multiple-targets.html, which depends on Bug 1359311.
Attachment #8860566 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•7 years ago
|
||
All tests passing with dependency patches applied. See https://github.com/szager-chromium/web-platform-tests/pull/1 for upstream PR.
Attachment #8861294 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8862740 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•7 years ago
|
||
Imports all tests but disabled by default. Plan is to re-enable them step by step with every dependency patch.
Attachment #8867812 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d7220d7db9b70e5231edc37e7b478a12fa09c0a
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8867960 -
Flags: review?(bugs)
|
||
Comment 8•7 years ago
|
||
Comment on attachment 8867960 [details] [diff] [review] web-platform tests for IntersectionObserver API >--- /dev/null >+++ b/testing/web-platform/meta/intersection-observer/__dir__.ini >@@ -0,0 +1,2 @@ >+disabled: true >+prefs: [dom.IntersectionObserver.enabled:true, dom.IntersectionObserver.enabled:true] Instead of disabling the entire test folder, please add web-platform/meta/test_name.html.ini files for each these tests with 'expected: FAIL' so we can enable each one together with the required bug fix. Add the relevant bug number to the .ini file.
|
|
Assignee | |
Comment 9•7 years ago
|
||
Disabled failing tests individualy with references to bug numbers.
Attachment #8867960 -
Attachment is obsolete: true
Attachment #8867960 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 10•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c631ad3a9e7946005772c8690b8bffc754226710
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8868379 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
|
|
||
Updated•7 years ago
|
Attachment #8868379 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 11•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81eed8f8d1ebed9b40f33facde7b047cc73f26dd&selectedJob=100521922
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → tschneider
|
||
Comment 12•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/067a43d46619 (intersection-observer) Import web-platform tests. r=jet
Keywords: checkin-needed
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/067a43d46619
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•