Closed Bug 1358666 Opened 8 years ago Closed 8 years ago

(intersection-observer) Import and enable web-platform tests

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: tschneider, Assigned: tschneider)

References

Details

Attachments

(1 file, 6 obsolete files)

web-platform tests for IntersectionObserver API
79.04 KB, patch
bugs
: review+
Details | Diff | Splinter Review
Lets get web-platform tests for the Intersection Observer API to work and enable them for better test coverage.
Depends on: 1335644
Attached patch WIP patch (obsolete) — — Splinter Review
Attached patch WIP patch (v2) (obsolete) — — Splinter Review
Attachment #8860564 - Attachment is obsolete: true
Depends on: 1358668
Depends on: 1359311
Attached patch WIP patch (v3) (obsolete) — — Splinter Review
All tests (with patches from dependencies) except of multiple-targets.html, which depends on Bug 1359311.
Attachment #8860566 - Attachment is obsolete: true
Depends on: 1359316
Depends on: 1359317
Depends on: 1359318
All tests passing with dependency patches applied. See https://github.com/szager-chromium/web-platform-tests/pull/1 for upstream PR.
Attachment #8861294 - Attachment is obsolete: true
Depends on: 1363650
Attachment #8862740 - Attachment is obsolete: true
Imports all tests but disabled by default. Plan is to re-enable them step by step with every dependency patch.
Attachment #8867812 - Attachment is obsolete: true
Attachment #8867960 - Flags: review?(bugs)
Comment on attachment 8867960 [details] [diff] [review] web-platform tests for IntersectionObserver API >--- /dev/null >+++ b/testing/web-platform/meta/intersection-observer/__dir__.ini >@@ -0,0 +1,2 @@ >+disabled: true >+prefs: [dom.IntersectionObserver.enabled:true, dom.IntersectionObserver.enabled:true] Instead of disabling the entire test folder, please add web-platform/meta/test_name.html.ini files for each these tests with 'expected: FAIL' so we can enable each one together with the required bug fix. Add the relevant bug number to the .ini file.
Disabled failing tests individualy with references to bug numbers.
Attachment #8867960 - Attachment is obsolete: true
Attachment #8867960 - Flags: review?(bugs)
Attachment #8868379 - Flags: review?(bugs)
Blocks: 1358668
No longer depends on: 1358668
Blocks: 1363650
No longer depends on: 1363650
Blocks: 1359318
No longer depends on: 1359318
Blocks: 1359311
No longer depends on: 1359311
Blocks: 1359316
No longer depends on: 1359316
Blocks: 1359317
No longer depends on: 1359317
Attachment #8868379 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Assignee: nobody → tschneider
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/067a43d46619 (intersection-observer) Import web-platform tests. r=jet
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/067a43d46619
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: