135877 - Drag-n-drop a card to a list/ab and the target is not highlighted

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Ninoschka Baca]

Trunk build 2002-04-05: WinMe

Overview: Drag-n-drop a card to a list or another address book in the directory 
pane and the target is not highlighted. This leaves the user wondering if the 
dnd process was successful.

Steps to reproduce:
1. Select a card from the results pane (right pane)
2. Drag it to a different address book in the directory pane (or a list)

Actual Results: The target address book never appears highlighted. The pointer 
is present with a little square (the card is copied to the destination).

Expected Results: If the mouse is on an address book/list then I would also 
expect it to be highlighted (i.e. dark blue).

Comment 1

[Ninoschka Baca]

Marking nsbeta1 since most users would expect the Drag-n-drop process to work 
similar to the 3pane window where messages are drag-n-dropped from the thread 
pane to the folder pane.

ryi: Since the mailing list dialog is modal there are 2 ways to create a list. 
Open the list and type/autocomplete in the list dialog or drag-n-drop the 
entries from the results pane to the directory pane. 

Comment 2

[Michael Buckland]

Discussed in Mail News bug mtg with Engineering QA and PjM.  Decided to minus
this bug.

Comment 3

[Ninoschka Baca]

Marking nsbeta1. If the target address book is not highlighted during a d-n-d
they may assume that it did not work.

Comment 4

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 5

[shliang]

Attachment: patch

convert dirTree to use xul tree builder, and fix dirTreeObserver so that dnd
feedback will work

Comment 6

[(not reading, please use [e-mail] instead)]

what about showing mailing lists, local, ldap, and secure ldap icons in the dir
tree?  does that work with your patch? 

I'll review more tomorrow.

Comment 7

[(not reading, please use [e-mail] instead)]

or is it the case that you can just make the switch to the tree builder, and the
old css just works?

Comment 8

[shliang]

the icons are still there (i don't think the css should have to change)

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 115439 [details] [diff] [review]
patch 

r/sr=sspitzer

I also smoketested this patch, and it looked good.

thanks shuehan, nice work.

Comment 10

[(not reading, please use [e-mail] instead)]

after you can you spin up a new bug about how sort order / direction is now
global (instead of per addressbook / mailing list?)

i don't think we should fix it right away, but we should log it, and then triage
it.  (I expect nsbeta1-)

Comment 11

[shliang]

marking fixed.

Comment 12

[Ninoschka Baca]

Trunk build 2003-03-03: WinXP, Linux RH 8
Verified Fixed, and I also still see the mailing lists, local, ldap, and secure
ldap icons.