1358840 - Twisties are gone, cannot expand threads, folders, or accounts

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Axel Hecht [:Pike]]

I bet this is a toolkit change regressing thunderbird, but I didn't find one ad-hoc.

Filing a bug to track this.

Marking as blocker 'cause I can't get to my newsgroups at all right now.

Comment 1

[Richard Marti (:Paenglab)]

Axel, can you add the TB version and the platform?

Comment 2

[Jorg K (CEST = GMT+2)]

Works for me on Windows on latest Tinderbox build (Sat Apr 22 2017, 23:37:04), which has the same M-C base as today's Daily currently being built.

Comment 3

[Axel Hecht [:Pike]]

20170423030209, macos, German localization

Comment 4

[Richard Marti (:Paenglab)]

Yes I see it too also the treeitems aren't highlighted, FX is okay. Last good Daily from 20.4.2017, first bad 22.4.2017. Unfortunately 21.4.2017 Daily is busted. I tried the tinderbox builds and the last good is

20170421013227
https://hg.mozilla.org/comm-central/rev/7e82cc51efb47557a5568f331c28a55429274a46
https://hg.mozilla.org/mozilla-central/rev/8b854986038cf3f3f240697e27ef48ea65914c13

And the first bad

20170421155419
https://hg.mozilla.org/comm-central/rev/756dadb206f5d280ce8b1f80eda047e7f5fa1e92
https://hg.mozilla.org/mozilla-central/rev/ff6abe20041933a67f636b748ed698e9616a6833

Stefan, please could you check what could cause this?

Comment 5

[Richard Marti (:Paenglab)]

Axel, double-click opens/closes the treeitems.

Comment 6

[Jorg K (CEST = GMT+2)]

M-C range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8b854986038cf3f3f240697e27ef48ea65914c13&tochange=ff6abe20041933a67f636b748ed698e9616a6833

C-C range:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=7e82cc51efb47557a5568f331c28a55429274a46&tochange=756dadb206f5d280ce8b1f80eda047e7f5fa1e92
I don't see anything in the C-C range that could have caused this.

What do you mean by "FX is okay"? Where does it use twisties?

Comment 7

[Richard Marti (:Paenglab)]

In the bookmarks sidebar and also in the Library (Show All Bookmarks).

Comment 8

[Axel Hecht [:Pike]]

Another side-effect I just noticed is that in the folder view, the active folder isn't high-lighted. Active emails are, though.

Comment 9

[Stefan [:stefanh]]

Hmm, this sounds like the native styling isn't applied to the tree rows (Firefox twisties are actually icons, but thunderbird uses native styling). I wonder if the changes in bug 1357655 could have caused this. In bug 1357655, 'appearance: auto' was introduced in minimal-xul.css in order to make native styling (with '-moz-appearance') continue to work in xul documents, so it should work, but maybe there's something special going on here with the treechildren...

Comment 10

[Stefan [:stefanh]]

Richard tells me that a local backout of the patches in bug 1357655 make things work again.

Comment 11

[Jorg K (CEST = GMT+2)]

Well, can we port this bug or do we need to NI Mats and Boris. They're busily uplifting this to mozilla54 beta.

Comment 12

[Stefan [:stefanh]]

The regression is in Firefox as well. Basically, '-moz-appearance' have stopped working for treechildren.

Comment 13

[Richard Marti (:Paenglab)]

And adding in xul.css * { appearance: auto; } doesn't work.

Comment 14

[Richard Marti (:Paenglab)]

Moving it to toolkit.

Comment 15

[Stefan [:stefanh]]

It works if you in xul.css set appearance: auto on the pseudo-element:

treechildren::-moz-tree-twisty {
  appearance: auto;
}

However, I'm sure there's a better way to fix this (you'd for instance want it to work for tree rows as well).

Comment 16

[Mats Palmgren (inactive)]

Yeah, I think we need to add a rule covering all XUL pseudo elements in xul.css
that declares 'appearance: auto' for them.

Comment 17

[Mats Palmgren (inactive)]

Attachment: fix

These are all the XUL pseudo elements I could find.

Stefan, can you confirm this fixes the issues in TB please?

Comment 18

[Stefan [:stefanh]]

I'm at work atm, but I can confirm this around 8PM (UTC+2).

Comment 20

[Richard Marti (:Paenglab)]

With the patch, the twisties are back and also the treechildren are highlighted when selected.

Comment 21

[Stefan [:stefanh]]

Yeah, this fixes the issues in Thunderbird and Firefox.

Comment 22

[Mats Palmgren (inactive)]

Great, thanks!  It looks green-ish on Try too:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb409534eee20f740b620ce8117e8411c6097917

Comment 23

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8860775 [details] [diff] [review]
fix

This looks about right.

To make sure it's really right, we should change nsTreeBodyFrame::GetPseudoStyleContext and nsTreeStyleCache::GetStyleContext to take a nsICSSAnonBoxPseudo* instead of nsIAtom*, and then assert that IsTreePseudoElement().  That will require some changes to various other tree code, but will make this definitely safe...  Followup is ok for this part.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bff062c52125
Make appearance:auto the default for all XUL pseudo elements too.  r=bz

Comment 25

[Mats Palmgren (inactive)]

(Filed follow-up bug 1359205 for comment 23)

Comment 26

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/bff062c52125

Comment 28

[Stefan [:stefanh]]

[Tracking Requested - why for this release]: Bug 1357655 was uplifted to 54 and this is a regression from that bug.

Comment 29

[Jorg K (CEST = GMT+2)]

Comment on attachment 8860775 [details] [diff] [review]
fix

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1357655
[User impact if declined]: Wrong styling of treechildren, twisties not working on Mac, see comment #12.
[Is this code covered by automated tests?]: Indirectly, TB Mozmill failing (bug 1358711)
[Has the fix been verified in Nightly?]: Yes, Thunderbird Daily.
[Needs manual test from QE? If yes, steps to reproduce]: N/A.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: CSS only.
[String changes made/needed]: None.

Comment 30

[Axel Hecht [:Pike]]

Attachment: i haz twisties

Verified, see screenshot. I haz twisties.

Comment 31

[Axel Hecht [:Pike]]

VERIFIED in 20170425030218.

Comment 32

[Gerry Chang [:gchang]]

Track 54+ as regression.

Comment 33

[Gerry Chang [:gchang]]

Comment on attachment 8860775 [details] [diff] [review]
fix

Fix a regression and was verified. Beta54+. Should be in 54 beta 3.

Comment 34

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/910583861999

Comment 35

[Seb]

This bug still exists in release version of Thunderbird (52.1.1)
Is it a separate issue, or just need to wait for changes to propagate?

Comment 36

[Stefan [:stefanh]]

(In reply to Seb from comment #35)
> This bug still exists in release version of Thunderbird (52.1.1)
> Is it a separate issue, or just need to wait for changes to propagate?

This bug was never present in Thunderbird 52.x, so what you see must be a separate issue.

Comment 37

[Seb]

Well the (In reply to Stefan [:stefanh] from comment #36)
> This bug was never present in Thunderbird 52.x, so what you see must be a
> separate issue.

Well the twisties are definitely all gone in my TB 52.x
In the folders, accounts, and threaded-mode message list.

They are all ok in TB 54.0b3 so I guess it's been fixed already, and will propagate to the release channel in due course...

Comment 38

[Stefan [:stefanh]]

(In reply to Seb from comment #37)
> Well the (In reply to Stefan [:stefanh] from comment #36)
> > This bug was never present in Thunderbird 52.x, so what you see must be a
> > separate issue.
> 
> Well the twisties are definitely all gone in my TB 52.x

I believe you (even though the twisties are not gone in my 52.1.1 with MacOS Sierra) :-)
But the code that caused this particular issue was never introduced in 52.x, so what you see is not the same issue as described in this bug.

Comment 39

[Richard Marti (:Paenglab)]

Seb, on what platform/distro are you? If you have Firefox (which version?), can you check in the Library window if the twisties are also missing?

Comment 40

[Seb]

I'm using Windows 8.1 (64bit)

Thunderbird 52.1.1 (release) is missing all twisties.  Can still click where they should be and the action happens.

Thunderbird 54.0b3 (beta) is fine.

Firefox 53.0.3 is fine (twisties showing in Library window).

Comment 41

[Richard Marti (:Paenglab)]

Checked TB 52.1.1 on Win8.1 and the twisties are present. Seb, please can you try to restart with Add-ons disabled, see Help menu?

Comment 42

[Seb]

Ah, that brings the twisties back when running in safe mode!

However, even when I disable all Extensions, Plugins and Dictionaries in normal mode, the twisties are still gone.

Under Appearance in the Addon-ons Manage, it has a message "Default is incompatible with Thunderbird 52.1.1.", and the Default theme has version 54.0.  Not sure how this has happened - maybe through installing beta versions for bug testing?  Am I right in thinking the theme is stored within the Profile directory?

Is it possible to reset the Default theme?

Comment 43

[Jorg K (CEST = GMT+2)]

I suggest you uninstall TB and manually delete the c:\program files (x86)\Mozilla Thunderbird\ directory. If I'm not mistaken, the default theme is installed there as a "distribution extension".

You can have many versions of TB installed in parallel, but you should install each one in a different directory.

Comment 44

[Seb]

After a reinstall, the twisties are back, hurray!
And the Default theme is now correctly 52.1.1

I'm not sure how this got changed to 54.0

I always install the beta versions in a separate directory.  The only 'cross-contamination' that may have happened was loading the profile used for beta testing, in my release TB.  And I'm pretty sure I never did it the other way around - loading my working/release profile with a beta version.

Anyway, many thanks for your help fixing this issue :)

Comment 45

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This was backed out in bug 1365614 (along with other bugs).