1359205 - Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom*

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Mats Palmgren (inactive)]

Follow-up from bug 1358840 comment 23:

> To make sure it's really right, we should change
> nsTreeBodyFrame::GetPseudoStyleContext and nsTreeStyleCache::GetStyleContext
> to take a nsICSSAnonBoxPseudo* instead of nsIAtom*, and then assert that
> IsTreePseudoElement().  That will require some changes to various other tree
> code, but will make this definitely safe...  Followup is ok for this part.

Comment 1

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b166d850bed695c55fc90aa2d50c99c2a09358cf

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8861193 [details] [diff] [review]
fix

r=me on these bits, but I meant that nsTreeStyleCache::GetStyleContext should assert IsTreePseudoElement(aPseudoElement).

Comment 4

[Mats Palmgren (inactive)]

Attachment: add an assertion

I'll fold this into the first part.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49979d9db6f50f2fa861afb31280f9b8520ce0e

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8861711 [details] [diff] [review]
add an assertion

r=me, thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5590452f092c
Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type.  r=bz

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5590452f092c