All users were logged out of Bugzilla on October 13th, 2018

Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom*

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Follow-up from bug 1358840 comment 23:

> To make sure it's really right, we should change
> nsTreeBodyFrame::GetPseudoStyleContext and nsTreeStyleCache::GetStyleContext
> to take a nsICSSAnonBoxPseudo* instead of nsIAtom*, and then assert that
> IsTreePseudoElement().  That will require some changes to various other tree
> code, but will make this definitely safe...  Followup is ok for this part.
(Assignee)

Updated

2 years ago
Blocks: 1358840
(Assignee)

Comment 2

2 years ago
Created attachment 8861193 [details] [diff] [review]
fix
Attachment #8861193 - Flags: review?(bzbarsky)
Comment on attachment 8861193 [details] [diff] [review]
fix

r=me on these bits, but I meant that nsTreeStyleCache::GetStyleContext should assert IsTreePseudoElement(aPseudoElement).
Attachment #8861193 - Flags: review?(bzbarsky) → review+
Comment on attachment 8861711 [details] [diff] [review]
add an assertion

r=me, thank you!
Attachment #8861711 - Flags: review?(bzbarsky) → review+

Comment 6

2 years ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5590452f092c
Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type.  r=bz

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5590452f092c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox57: affected → ---
You need to log in before you can comment on or make changes to this bug.