Closed Bug 1359205 Opened 4 years ago Closed 4 years ago
Make XUL pseudo values ns
ICSSAnon Box Pseudo* instead of ns IAtom*
Follow-up from bug 1358840 comment 23: > To make sure it's really right, we should change > nsTreeBodyFrame::GetPseudoStyleContext and nsTreeStyleCache::GetStyleContext > to take a nsICSSAnonBoxPseudo* instead of nsIAtom*, and then assert that > IsTreePseudoElement(). That will require some changes to various other tree > code, but will make this definitely safe... Followup is ok for this part.
Comment on attachment 8861193 [details] [diff] [review] fix r=me on these bits, but I meant that nsTreeStyleCache::GetStyleContext should assert IsTreePseudoElement(aPseudoElement).
Attachment #8861193 - Flags: review?(bzbarsky) → review+
I'll fold this into the first part. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49979d9db6f50f2fa861afb31280f9b8520ce0e
Attachment #8861711 - Flags: review?(bzbarsky)
Comment on attachment 8861711 [details] [diff] [review] add an assertion r=me, thank you!
Attachment #8861711 - Flags: review?(bzbarsky) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5590452f092c Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type. r=bz
You need to log in before you can comment on or make changes to this bug.