Closed Bug 1359205 Opened 4 years ago Closed 4 years ago

Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom*

Categories

(Core :: XUL, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(2 files)

Follow-up from bug 1358840 comment 23:

> To make sure it's really right, we should change
> nsTreeBodyFrame::GetPseudoStyleContext and nsTreeStyleCache::GetStyleContext
> to take a nsICSSAnonBoxPseudo* instead of nsIAtom*, and then assert that
> IsTreePseudoElement().  That will require some changes to various other tree
> code, but will make this definitely safe...  Followup is ok for this part.
Blocks: 1358840
Attached patch fixSplinter Review
Attachment #8861193 - Flags: review?(bzbarsky)
Comment on attachment 8861193 [details] [diff] [review]
fix

r=me on these bits, but I meant that nsTreeStyleCache::GetStyleContext should assert IsTreePseudoElement(aPseudoElement).
Attachment #8861193 - Flags: review?(bzbarsky) → review+
Comment on attachment 8861711 [details] [diff] [review]
add an assertion

r=me, thank you!
Attachment #8861711 - Flags: review?(bzbarsky) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5590452f092c
Make XUL pseudo values nsICSSAnonBoxPseudo* instead of nsIAtom* and assert that IsTreePseudoElement() got a pseudo tag of the right type.  r=bz
https://hg.mozilla.org/mozilla-central/rev/5590452f092c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.