Closed Bug 1358961 Opened 3 years ago Closed 3 years ago

IsPartOfOpaqueLayer should consider ColorLayer as well.

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

Attachments

(1 file)

There are some tests will check the result layer is opaque or not by calling nsDOMWindowUtils::IsPartOfOpaqueLayer and this function assume that the layer is always PaintedLayer. But when 'layers.advanced.background-color' is enabled, layer might be converted to ColorLayer. So I add ColorLayer into consideration.
Comment on attachment 8860826 [details]
Bug 1358961 - IsPartOfOpaqueLayer should consider ColorLayer as well.

https://reviewboard.mozilla.org/r/132818/#review135646
Attachment #8860826 - Flags: review?(matt.woodrow) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fda2d8db390
IsPartOfOpaqueLayer should consider ColorLayer as well. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/1fda2d8db390
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1370088
You need to log in before you can comment on or make changes to this bug.