1358961 - IsPartOfOpaqueLayer should consider ColorLayer as well.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

There are some tests will check the result layer is opaque or not by calling nsDOMWindowUtils::IsPartOfOpaqueLayer and this function assume that the layer is always PaintedLayer. But when 'layers.advanced.background-color' is enabled, layer might be converted to ColorLayer. So I add ColorLayer into consideration.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1358961 - IsPartOfOpaqueLayer should consider ColorLayer as well.

Review commit: https://reviewboard.mozilla.org/r/132818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132818/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8860826 [details]
Bug 1358961 - IsPartOfOpaqueLayer should consider ColorLayer as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132818/diff/1-2/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8860826 [details]
Bug 1358961 - IsPartOfOpaqueLayer should consider ColorLayer as well.

https://reviewboard.mozilla.org/r/132818/#review135646

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=30f3305d43a5d0423050c9df4bd1ccb5fa8c5c14

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fda2d8db390
IsPartOfOpaqueLayer should consider ColorLayer as well. r=mattwoodrow

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1fda2d8db390