1359206 - Fix CompositionTime and CompositeUntil handling of WebRenderImageHost

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix composite time handling of WebRenderImageHost

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5130a1e12189e06c4e7cfe12f6fe38d4dc7abc1

Comment 3

[Sotaro Ikeda [:sotaro]]

d attachment 8861158 [details] [diff] [review] uses WebRenderBridgeParent to hold composite until time. It is not good, since WebRenderBridgeParent could be non root WebRenderBridgeParent.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix composite time handling of WebRenderImageHost

Comment 5

[Nicolas Silva [:nical]]

Sorry missed that one, I'll look into it tomorrow. It would be great If you wrote a quick summary in the bug (even if the fix is seemingly simple), so that we can quickly understand what the change is about next time we need to dig into the hg logs.

Comment 6

[Sotaro Ikeda [:sotaro]]

attachment 8861440 [details] [diff] [review] changes WebRenderImageHost as to work more likely to ImageHost about handling of CompositionTime and CompositeUntil.

But architecture is different between WebRenderImageHost and ImageHost. In ImageHost case, HostLayerManager(LayerManagerComposite) manages CompositionTime and CompositeUntil. In WebRenderImageHost case, we need a similar role object. But WebRenderBridgeParent seems not fit to it, since there are non root WebRenderBridgeParents. Then I chose WebRenderCompositableHolder as to hold CompositionTime and CompositeUntil, since it is already shared by all WebRenderBridgeParents.

The followings are main change of WebRenderImageHost.
- WebRenderImageHost::UseTextureHost() is changed as to call CompositeUntil()
- WebRenderImageHost::GetCompositionTime() is changed to get composition time
    by calling mWrCompositableHolder->GetCompositionTime()
- Added WebRenderImageHost::GetAsTextureHostForComposite(). It is used for composition.
  If we just want to select TextureHost, WebRenderImageHost::GetAsTextureHost() is enough.
  But it does not update mLastFrameID and mLastProducerID.
  The GetAsTextureHostForComposite() is used as similar to ImageHost::Composite()

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56008680db19a31a9155229ae67dc54db3edc0e9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/6b0f3a894ad2
Fix CompositionTime and CompositeUntil handling of WebRenderImageHost r=nical

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/6b0f3a894ad2