Closed
Bug 1345054
Opened 8 years ago
Closed 8 years ago
Investigate to allocate pipleline for each video
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(2 files, 24 obsolete files)
60.56 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
10.44 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
To support video correctly, we need to choose either. This bug is for investigating [1]
-[1] Allocate pipleline for each video
-[2] Update display list for each video frame size/format change
-[3] Add ImageContainer like display list item to webrender.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•8 years ago
|
||
Very early implementation.
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8849392 -
Attachment is obsolete: true
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8851516 -
Attachment is obsolete: true
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8854752 -
Attachment is obsolete: true
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8860361 -
Attachment is obsolete: true
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8862143 -
Attachment is obsolete: true
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8862625 -
Attachment is obsolete: true
Assignee | ||
Comment 11•8 years ago
|
||
Fixed crashes. Need to reduce key generation.
Attachment #8862924 -
Attachment is obsolete: true
Assignee | ||
Comment 13•8 years ago
|
||
Attachment #8868914 -
Attachment is obsolete: true
Assignee | ||
Comment 14•8 years ago
|
||
Attachment #8868915 -
Attachment is obsolete: true
Assignee | ||
Comment 15•8 years ago
|
||
Attachment #8869359 -
Attachment is obsolete: true
Assignee | ||
Comment 16•8 years ago
|
||
Attachment #8869364 -
Attachment is obsolete: true
Assignee | ||
Comment 17•8 years ago
|
||
Assignee | ||
Comment 18•8 years ago
|
||
Fixed problems when e10s was disabled.
Attachment #8869398 -
Attachment is obsolete: true
Assignee | ||
Comment 19•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccdba27d4f6d3bd0cd91003cfbad4c724a4f31e7
Some test failures were caused by async pipeline id allocation.
When pipeline id allocation was changed to sync, some problems were addressed.
Assignee | ||
Comment 20•8 years ago
|
||
Attachment #8869905 -
Attachment is obsolete: true
Assignee | ||
Comment 21•8 years ago
|
||
Assignee | ||
Comment 22•8 years ago
|
||
Attachment #8870278 -
Attachment is obsolete: true
Assignee | ||
Comment 23•8 years ago
|
||
Attachment #8871689 -
Attachment is obsolete: true
Assignee | ||
Comment 24•8 years ago
|
||
Assignee | ||
Comment 26•8 years ago
|
||
Comment on attachment 8872509 [details] [diff] [review]
patch part 1 - Allocate pipleline for each video
[Security approval request comment]
How easily could an exploit be constructed based on the patch?
> It is not easy to exploit based on the patch.
Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?
> No.
Which older supported branches are affected by this flaw?
> The bug affects since Firefox 32.
If not all supported branches, which bug introduced the flaw?
> Bug 1006957.
Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?
> No, but it is easy to create a patch and it is not risky.
How likely is this patch to cause regressions; how much testing does it need?
> It is not likely to cause a regression. I tested locally and on tryserver, it seems enough.
Attachment #8872509 -
Flags: sec-approval?
Assignee | ||
Updated•8 years ago
|
Attachment #8872509 -
Flags: sec-approval?
Assignee | ||
Comment 27•8 years ago
|
||
Please ignore Comment 26.
Assignee | ||
Updated•8 years ago
|
Attachment #8872509 -
Attachment description: patch - Allocate pipleline for each video → patch part 1 - Allocate pipleline for each video
Assignee | ||
Comment 28•8 years ago
|
||
Assignee | ||
Comment 29•8 years ago
|
||
Attachment #8872531 -
Attachment is obsolete: true
Assignee | ||
Comment 30•8 years ago
|
||
Attachment #8872534 -
Attachment is obsolete: true
Assignee | ||
Comment 31•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8872509 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•8 years ago
|
Attachment #8872589 -
Flags: review?(nical.bugzilla)
Comment 32•8 years ago
|
||
Comment on attachment 8872509 [details] [diff] [review]
patch part 1 - Allocate pipleline for each video
Review of attachment 8872509 [details] [diff] [review]:
-----------------------------------------------------------------
I started reviewing this and so far so good, it's a lot to chew so it's going to take a bit more time but I am on it I promise!
Assignee | ||
Comment 33•8 years ago
|
||
Thanks!
Updated•8 years ago
|
Attachment #8872509 -
Flags: review?(nical.bugzilla) → review+
Comment 34•8 years ago
|
||
Comment on attachment 8872589 [details] [diff] [review]
patch part 2 - Reduce DisplayList update and ImageKey generation
Review of attachment 8872589 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/wr/WebRenderCompositableHolder.cpp
@@ +300,5 @@
> + aKeysToDelete.AppendElements(aHolder->mKeys);
> + aHolder->mKeys.Clear();
> + aHolder->mCurrentTexture = nullptr;
> +
> + // No txture to render
nit: texture
Attachment #8872589 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 35•8 years ago
|
||
Rebased.
Attachment #8872509 -
Attachment is obsolete: true
Attachment #8873690 -
Flags: review+
Assignee | ||
Comment 36•8 years ago
|
||
Rebased.
Attachment #8872589 -
Attachment is obsolete: true
Attachment #8873693 -
Flags: review+
Assignee | ||
Comment 37•8 years ago
|
||
Comment 38•8 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c57e39a677a
part 1 - Allocate pipleline for each video r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f944d9ffbe0
part 2 -Reduce DisplayList update and ImageKey generation r=nical
Comment 39•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c57e39a677a
https://hg.mozilla.org/mozilla-central/rev/5f944d9ffbe0
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•