1359276 - Make "LEGACY" badge link to sumo

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Andrew Swan [:aswan]]

The badge next to legacy add-ons in bug 1354682 is supposed to link to a support.mozilla.org page explaining the webextensions transition.  But the page is not available due to turmoil on SUMO.  So bug 1354682 will land without the link, this bug is to go back and make the badge link to the page when it becomes available (bug 1354684)

Comment 1

[:shell escalante]

follow up with erin - current it's rolled back to kitsune... erin checking what new content needs to be

Comment 2

[:shell escalante]

adding link to github related issue for consistent SUMO answer (from amy) https://github.com/mozilla/addons-server/issues/4974

Comment 3

[:shell escalante]

Vadliated with Amy that this Legacy badge bug should link to the same explanation as the other github issue at https://support.mozilla.org/kb/firefox-add-technology-modernizing

Amy added the info covering Legacy to that link.  There are no solid plans to change how we are doing it yet (from this rolled back Kitsune format) - so go with this format.

Joni: "This link will automatically redirect to the different locales. Just be aware that we might have to change the link when we move back to the new platform, but the above link will work in the interim. We'll keep you posted if changes come."

Comment 4

[Andrew Swan [:aswan]]

(In reply to :shell escalante from comment #3)
> Vadliated with Amy that this Legacy badge bug should link to the same
> explanation as the other github issue at
> https://support.mozilla.org/kb/firefox-add-technology-modernizing

Doing this means just hard-coding that link.  Everything else in about:addons uses the app.support.baseURL preference, which is https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/
We have pages under those types of URLs that work today for things like unsigned-addons and npapi.  Is it possible to get a similarly formatted one for legacy addons?

Comment 5

[Joni Chan]

Hi @aswan, you can use the same format (https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/) for legacy addons. Here's what it would look like:

https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/webextensions

It will redirect to the same article mentioned in comment #3, but please give it a shot and let me know if it doesn't work.

Comment 6

[Andrew Swan [:aswan]]

Attachment: Bug 1359276 Part 2 Make legacy badge link to sumo

Review commit: https://reviewboard.mozilla.org/r/135952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135952/

Comment 7

[Andrew Swan [:aswan]]

Attachment: Bug 1359276 Part 1 Use a lazy preference getter for app.support.baseURL

Review commit: https://reviewboard.mozilla.org/r/135954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135954/

Comment 8

[Andrew Swan [:aswan]]

Comment on attachment 8864323 [details]
Bug 1359276 Part 2 Make legacy badge link to sumo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135952/diff/1-2/

Comment 9

[Andrew Swan [:aswan]]

Comment on attachment 8864325 [details]
Bug 1359276 Part 1 Use a lazy preference getter for app.support.baseURL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135954/diff/1-2/

Comment 10

[Andrew Swan [:aswan]]

Comment on attachment 8864323 [details]
Bug 1359276 Part 2 Make legacy badge link to sumo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135952/diff/2-3/

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 8864325 [details]
Bug 1359276 Part 1 Use a lazy preference getter for app.support.baseURL

https://reviewboard.mozilla.org/r/135954/#review139016

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 8864323 [details]
Bug 1359276 Part 2 Make legacy badge link to sumo

https://reviewboard.mozilla.org/r/135952/#review139020

::: toolkit/themes/shared/extensions/extensions.inc.css:472
(Diff revision 3)
>  
> +.legacy-warning:hover {
> +  background-color: #D7B600;
> +  color: #3E2800;
> +  text-decoration: none;
> +}

I'm assuming text-link has an appropriate pointer set on it already.

Comment 13

[Andrew Swan [:aswan]]

Comment on attachment 8864323 [details]
Bug 1359276 Part 2 Make legacy badge link to sumo

https://reviewboard.mozilla.org/r/135952/#review139020

> I'm assuming text-link has an appropriate pointer set on it already.

You mean the cursor attribute?  That just comes from global.css, eg. http://searchfox.org/mozilla-central/rev/b0e1da2a90ada7e00f265838a3fafd00af33e547/toolkit/themes/linux/global/global.css#264

Comment 14

[Andrew Swan [:aswan]]

Comment on attachment 8864323 [details]
Bug 1359276 Part 2 Make legacy badge link to sumo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135952/diff/3-4/

Comment 15

[Andrew Swan [:aswan]]

The only change in the last interdiff was to add "-moz-user-focus: ignore;" to the legacy badge.
This was the expedient way to keep from breaking browser_list.js but it occurs to me that this might hamper accessibility?
How important is it that we let that badge get focus?

Comment 16

[Dave Townsend [:mossop]]

(In reply to Andrew Swan [:aswan] from comment #15)
> The only change in the last interdiff was to add "-moz-user-focus: ignore;"
> to the legacy badge.
> This was the expedient way to keep from breaking browser_list.js but it
> occurs to me that this might hamper accessibility?
> How important is it that we let that badge get focus?

I don't think it's that important given that this message will go away in a few releases.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92ec85d18495
Part 1 Use a lazy preference getter for app.support.baseURL r=mossop
https://hg.mozilla.org/integration/autoland/rev/952c5438a347
Part 2 Make legacy badge link to sumo r=mossop

Comment 18

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/92ec85d18495
https://hg.mozilla.org/mozilla-central/rev/952c5438a347

Comment 19

[Vasilica Tamas, QA [:vtamas]]

I can confirm that “LEGACY” badge is correctly linked to sumo page https://support.mozilla.org/en-US/kb/firefox-add-technology-modernizing?as=u&utm_source=inproduct. Tested on Firefox 55.0a1 (2017-06-05) using a few localizations under Windows 10 64-bit and Ubuntu 16.04 32-bit.