Closed
Bug 1359278
Opened 7 years ago
Closed 7 years ago
Typo in UnifiedComplete causes browser.urlbar.restrict.searches not to be used
Categories
(Toolkit :: Places, defect, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
It's written as "restrict.searces" -- there's a missing H in "searces". That can't be right, right? https://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/UnifiedComplete.js#40
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8861261 [details] Bug 1359278 - Typo in UnifiedComplete causes browser.urlbar.restrict.searches not to be used. https://reviewboard.mozilla.org/r/133208/#review136914 yeah looks like we don't test these. Not critical since it's a really edge case, so I'm fine to land this without a test for now. Please file a bug to add a test for manual setting a restriction char, and make it block bug 1315509, we'll look into it when (if) we'll finally make "?" special.
Attachment #8861261 -
Flags: review?(mak77) → review+
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51e4497a7bbe Typo in UnifiedComplete causes browser.urlbar.restrict.searches not to be used. r=mak
|
Assignee | |
Comment 4•7 years ago
|
||
I filed bug 1360040 for the test.
|
||
Updated•7 years ago
|
status-firefox55:
--- → affected
status-firefox57:
affected → ---
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/51e4497a7bbe
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•7 years ago
|
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•