1359488 - Hamburger menu update badge overlaps tab bar when using compact tabs theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

See the attached screenshot. I've only tested Mac. I don't know if Windows or Linux are affected.

Comment 1

[Dão Gottwald [:dao]]

The update badge appears to have changed recently. Have you actually reproduced this in Firefox 55 or just Nightly?

Comment 2

[:Gijs (out for now; he/him)]

Pretty sure that round icon is the new icon... This reproduces for me on nightly from yesterday (24-04) with the dark compact theme.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Dão Gottwald [::dao] from comment #1)
> The update badge appears to have changed recently. Have you actually
> reproduced this in Firefox 55 or just Nightly?

I'm running Nightly, which is version 55. I haven't tested any other channels.

I see this on Windows too.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Chris Peterson [:cpeterson] from comment #3)
> (In reply to Dão Gottwald [::dao] from comment #1)
> > The update badge appears to have changed recently. Have you actually
> > reproduced this in Firefox 55 or just Nightly?
> 
> I'm running Nightly, which is version 55.

Oops, yes.

I suspect bug 893505 caused this.

Comment 5

[Alex Thayer [:alexical] (she/her)]

I believe this is no longer an issue. I can't observe this on low or high DPI displays, and I think we even have a couple pixels' worth of wiggle room.

Comment 6

[David Durst [:ddurst]]

Chris -- can you verify?

Comment 7

[Chris Peterson [:cpeterson]]

Verified fixed in Nightly 55 build 2017-05-24. Thanks!