1359696 - [Form Autofill] Move form autofill preference to Forms & Passwords group

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement)

Description

[Scott Wu [:scottwu]]

Move Form Autofill preference group into Forms & Passwords section, and keep it as it is in the old organization.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1359696 - Move form autofill preference to Forms & Passwords group.

Review commit: https://reviewboard.mozilla.org/r/133872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133872/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8861883 [details]
Bug 1359696 - Move form autofill preference to Forms & Passwords group.

https://reviewboard.mozilla.org/r/133872/#review137160

r+ with one comment below.

::: browser/extensions/formautofill/FormAutofillParent.jsm:98
(Diff revision 1)
> +        let useOldOrganization = Services.prefs.prefHasUserValue(oldOrganizationFlag) ?
> +                                 Services.prefs.getBoolPref(oldOrganizationFlag) :
> +                                 false;

`getBoolPref` was recently updated to support a default value as the second parameter (bug 1338306), so you don't need `prefHasUserValue` here.

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8861883 [details]
Bug 1359696 - Move form autofill preference to Forms & Passwords group.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133872/diff/1-2/

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8861883 [details]
Bug 1359696 - Move form autofill preference to Forms & Passwords group.

https://reviewboard.mozilla.org/r/133872/#review137160

> `getBoolPref` was recently updated to support a default value as the second parameter (bug 1338306), so you don't need `prefHasUserValue` here.

Oh good to know! I've made the change.

Comment 5

[Scott Wu [:scottwu]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69d1e0ac65cd215735f7d72f27ce8e64f7925e49

There are a few oranges but look unrelated to this patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e2534772f2d
Move form autofill preference to Forms & Passwords group. r=lchang

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0e2534772f2d