Closed Bug 1359696 Opened 3 years ago Closed 3 years ago

[Form Autofill] Move form autofill preference to Forms & Passwords group

Categories

(Toolkit :: Form Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file)

Move Form Autofill preference group into Forms & Passwords section, and keep it as it is in the old organization.
Comment on attachment 8861883 [details]
Bug 1359696 - Move form autofill preference to Forms & Passwords group.

https://reviewboard.mozilla.org/r/133872/#review137160

r+ with one comment below.

::: browser/extensions/formautofill/FormAutofillParent.jsm:98
(Diff revision 1)
> +        let useOldOrganization = Services.prefs.prefHasUserValue(oldOrganizationFlag) ?
> +                                 Services.prefs.getBoolPref(oldOrganizationFlag) :
> +                                 false;

`getBoolPref` was recently updated to support a default value as the second parameter (bug 1338306), so you don't need `prefHasUserValue` here.
Attachment #8861883 - Flags: review?(lchang) → review+
Comment on attachment 8861883 [details]
Bug 1359696 - Move form autofill preference to Forms & Passwords group.

https://reviewboard.mozilla.org/r/133872/#review137160

> `getBoolPref` was recently updated to support a default value as the second parameter (bug 1338306), so you don't need `prefHasUserValue` here.

Oh good to know! I've made the change.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69d1e0ac65cd215735f7d72f27ce8e64f7925e49

There are a few oranges but look unrelated to this patch.
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e2534772f2d
Move form autofill preference to Forms & Passwords group. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0e2534772f2d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.