1362583 - [Form Autofill] Autofill preferences should appear before the master password ones

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Matthew N. [:MattN]]

According to the UX spec master password should be last: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/228643733

Also add the missing "accessory-button" class for consistent button width.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1362583 - [Form Autofill] Move autofill preferences before master password ones.

Review commit: https://reviewboard.mozilla.org/r/136690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136690/

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8865031 [details]
Bug 1362583 - [Form Autofill] Move autofill preferences before master password ones.

https://reviewboard.mozilla.org/r/136690/#review139794

Sorry I must have misread the spec, thanks a lot for catching this.

::: browser/extensions/formautofill/FormAutofillParent.jsm:107
(Diff revision 1)
>          let parentNode = useOldOrganization ?
>                           document.getElementById("mainPrefPane") :
>                           document.getElementById("passwordsGroup");
>          let insertBeforeNode = useOldOrganization ?
>                                 document.getElementById("locationBarGroup") :
> -                               null;
> +                               document.getElementById("masterPasswordRow");

I originally thought `masterPasswordRow` should be `passwordGrid` but then I saw Bug 1362571. So this should work just fine after 1362571 lands.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dec9c58639c
[Form Autofill] Move autofill preferences before master password ones. r=scottwu

Comment 4

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/7dec9c58639c