[Form Autofill] Autofill preferences should appear before the master password ones

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Form Manager
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

53 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [form autofill:M2], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

According to the UX spec master password should be last: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/228643733

Also add the missing "accessory-button" class for consistent button width.
Comment hidden (mozreview-request)
Whiteboard: [form autofill:M2]

Comment 2

a year ago
mozreview-review
Comment on attachment 8865031 [details]
Bug 1362583 - [Form Autofill] Move autofill preferences before master password ones.

https://reviewboard.mozilla.org/r/136690/#review139794

Sorry I must have misread the spec, thanks a lot for catching this.

::: browser/extensions/formautofill/FormAutofillParent.jsm:107
(Diff revision 1)
>          let parentNode = useOldOrganization ?
>                           document.getElementById("mainPrefPane") :
>                           document.getElementById("passwordsGroup");
>          let insertBeforeNode = useOldOrganization ?
>                                 document.getElementById("locationBarGroup") :
> -                               null;
> +                               document.getElementById("masterPasswordRow");

I originally thought `masterPasswordRow` should be `passwordGrid` but then I saw Bug 1362571. So this should work just fine after 1362571 lands.
Attachment #8865031 - Flags: review?(scwwu) → review+

Comment 3

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dec9c58639c
[Form Autofill] Move autofill preferences before master password ones. r=scottwu

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7dec9c58639c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.