1359747 - Massive Mozmill failure on 2017-04-26: Port bug 1251198 |Align document.createEvent() supported events with spec| to C-C

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_reorder_buttons
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_separate_window [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_remove_buttons [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_add_tag_with_really_long_label [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_more_button_with_many_recipients [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_clicking_star_opens_inline_contact_editor [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_msg_id_context_menu [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_address_book_switch_disabled_on_contact_in_mailing_list [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_that_msg_without_date_clears_previous_headers [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_more_widget [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_show_all_header_mode [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_more_widget_with_maxlines_of_3 [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-message-header.js | test-message-header.js::test_more_widget_with_disabled_more [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-phishing-bar.js | test-phishing-bar.js::test_ignore_phishing_warning_from_message [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-phishing-bar.js | test-phishing-bar.js::test_no_phishing_warning_for_ip_sameish_text [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-phishing-bar.js | test-phishing-bar.js::test_no_phishing_warning_for_subdomain [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-phishing-bar.js | test-phishing-bar.js::test_phishing_warning_for_local_domain [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_reply_no_matching_identity [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_reply_matching_only_deliveredto [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_reply_matching_subaddress [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_reply_to_matching_second_id [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_deliveredto_to_matching_only_parlty [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-identity.js | test-reply-identity.js::test_reply_to_self_second_id [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-reply-to-list-from-address-selection.js | test-reply-to-list-from-address-selection.js::test_Reply_To_List_From_Address [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_no_mdn_for_normal_msgs [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_basic_mdn_shown [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_basic_mdn_shown_nonrfc [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_mdn_when_from_and_disposition_to_differs [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_mdn_when_from_and_disposition_to_differs_nonrfc [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_mdn_when_disposition_to_multi [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-return-receipt.js | test-return-receipt.js::test_mdn_when_disposition_to_multi_nonrfc [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\tabmail\test-tabmail-customize.js | test-tabmail-customize.js::test_redirects_toolbarbutton_drops [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\tabmail\test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_reorder_tabbar [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\tabmail\test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_reorder_window [log…]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\tabmail\test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_reorder_detach [log…]

M-C last good: a30dc237c3a600a5231f2974fc2b85dfb5
M-C first bad: 3f0c8da53c5cb015933b10b52ded3f3043

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a30dc237c3a600a5231f2974fc2b85dfb5&tochange=3f0c8da53c5cb015933b10b52ded3f3043

Comment 1

[Jorg K (CEST = GMT+2)]

Sample log:

https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1493188226/comm-central_win7_ix_test-mozmill-bm110-tests1-windows-build4.txt.gz

INFO -  SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\message-header\test-header-toolbar.js | test-header-toolbar.js::test_customize_header_toolbar_reorder_buttons
INFO -    EXCEPTION: Operation is not supported
INFO -      at: nonesuch line 181
INFO -         _synthesizeDragEvent test-mouse-event-helpers.js:181 15
INFO -         synthesize_drag_over test-mouse-event-helpers.js:112 3
INFO -         drag_n_drop_element test-mouse-event-helpers.js:55 3
INFO -         test_customize_header_toolbar_reorder_buttons test-header-toolbar.js:174 5

So _synthesizeDragEvent() fails at line 181:
https://dxr.mozilla.org/comm-central/rev/5e4e889f13eb1fd5091f60921a1566c661f2c630/mail/test/mozmill/shared-modules/test-mouse-event-helpers.js#181
which is:  let event = aWindow.document.createEvent("DragEvents");

So bug 1251198: https://hg.mozilla.org/mozilla-central/rev/7d70c64683b8

Looks like "DragEvents" was removed here:
https://hg.mozilla.org/mozilla-central/rev/7d70c64683b8#l9.62

Olli, Aryeh: What is the replacement? Just "dragevent"?

Comment 2

[Jorg K (CEST = GMT+2)]

We use document.createEvent quite a bit:
https://dxr.mozilla.org/comm-central/search?q=document.createEvent&redirect=false
document.createEvent("Events");
document.createEvent("UIEvents");
document.createEvent("XULCommandEvent");
document.createEvent("KeyboardEvent");
document.createEvent("DragEvents");
document.createEvent('MouseEvent');
document.createEvent("KeyEvents");
document.createEvent("CustomEvent");

Looks like only "DragEvents" might be removed:
https://hg.mozilla.org/mozilla-central/rev/7d70c64683b8#l30.3

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

DragEvent should work

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1359747-DragEvent.patch

Let's see whether this helps:
https://hg.mozilla.org/try-comm-central/pushloghtml?changeset=3a9dec285c89c620390e7ba4cabe1b51cf3e09da

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/8b236dd594d9127fc42e8996d447884628b4ff33

Comment 6

[:aceman]

Comment on attachment 8861854 [details] [diff] [review]
1359747-DragEvent.patch

Review of attachment 8861854 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.