135983 - Drag bookmark or folder onto Bookmarks button on Personal Toolbar deletes bookmark, no error msg

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Francis Chin]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.9+) Gecko/20020405
BuildID:    2002040503

On the Bookmarks menu shown from the Personal Toolbar, dropping any bookmark or
folder you don't mind losing on the Bookmarks icon deletes the bookmark (or
folder). The bookmark/folder is lost and cannot be found in the bookmarks.html file.

This bug is similar to http://bugzilla.mozilla.org/show_bug.cgi?id=116815

Reproducible: Always
Steps to Reproduce:
1. Create a bookmark you don't mind losing.
2. Click on 'Bookmarks' on the Personal Toolbar and start dragging the bookmark
you've just created.
3. Drop this on the 'Bookmarks' icon that you clicked on to open the bookmarks menu.
4. See it disappear before your very eyes.

Actual Results:  The bookmark dropped is deleted from the bookmark menu, and is
lost from bookmarks.html.

Expected Results:  Either:
1. Move the bookmark to the Personal Toolbar positioned just to the right of the
'Bookmarks' icon (i.e. as the left-most bookmark) - indicating this by a
vertical bar in that position while dragging over 'Bookmarks'.
Or:
2. Don't allow the bookmark to be dropped over 'Bookmarks' - change the mouse
pointer to the 'prohibited' symbol (or whatever it is called) and ignore the
drag if released over 'Bookmarks'.

This also happens if you're dragging the bookmark/folder from the Personal
Toolbar itself.

It results in minor dataloss (but major if you are dragging a whole folder of
bookmarks!), but managed to catch me out when rearranging my Personal Toolbar
bookmarks.

Comment 1

[R.K.Aa.]

Dataloss isn't minor. Adding keyword.

Comment 2

[Chris Lyon]

Related to/dupe of bug 135135?

Comment 3

[ahackett]

I'm afraid this isn't just limited to the Personal Toolbar. I was using build
2002040803 on Win2k and was attempting to organise the mess that is my bookmarks
and went to Bookmarks->Manage Bookmarks and, rather ironically, tried to drag
and drop my Bugzilla folder into the Mozilla one only to have all the bookmarks
disappear. I have since downloaded build 2002040903 and found it has the same
problem.

As with the main title there is no error msg produced.

Comment 4

[R.K.Aa.]

*** Bug 140459 has been marked as a duplicate of this bug. ***

Comment 5

[Dave]

In Comment 3, unless you are saying that your bookmarks disappeared when you
dragged them on to the "Bookmarks" pseudo-folder/button on the PT specifically,
it is not this bug (if you are talking about dragging them into some PT folder
somewhere, look at Bug 135135).  The more I think of it, the more it sounds like
Bug 135135, but I don't know the code, so I can't say for sure. This bug still
occurs on Win98, 2002050608.
I think the summary should be changed to incorporate these two observations:
1) dragging and dropping the proxy icon next to the URL on to the Bookmarks
folder has no effect (nothing is lost, because nothing was yet created)
2) it's not an error message we're interested in, or even some kind of feedback
(like the circle with the slash through it indicating "You can't do this" on
other drag-n-drop type events); really what we want is to create/move the
bookmark/bookmark folder in/into the Bookmark root
3) it's not like the bookmark was really deleted, it was just moved to nowhere
(which had the effect of "deleting" it)
I suggest a summary something like:
"DnD bookmark/folder/proxy icon onto Bookmarks button should move/create
bookmark into/in bookmarks root, not cause DnD item to disappear"
Comments?

Comment 6

[Pierre Chanial]

taking

Comment 7

[Pierre Chanial]

*** Bug 146732 has been marked as a duplicate of this bug. ***

Comment 8

[Pierre Chanial]

fixed by the checkin of bug 139471