1360121 - Youtube video will not appear in history list

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 9b55d0fd 
Device: iPad Air 2
iOS: 10.3.1

Steps to reproduce:
1. Go to youtube.com
2. Play a video 
3. Go to the History panel

Actual results:
- Visited videos do not appear in history list. The videos appear in the history list only after tapping the refresh button 

Note: 
- This issue is not reproducible in Safari or Chrome.
- I was able to reproduce this issue only on youtube videos.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 3

[Farhan Patel [:farhan]]

Comment on attachment 8868269 [details] [review]
GitHub Pull Request

Left a comment on GH.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: historytest.html

Minimal test case for `history.pushState` and `history.replaceState`.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8868269 [details] [review]
GitHub Pull Request

Farhan, I've updated the PR to the issues with the messed up project file and verified with the test case attached to this bug that we're not introducing any potential security issues with history.pushState/replaceState.

I also did some testing on a new branch to see if we can observe `KVOURL` and `KVOTitle` on the webview to achieve the same result and while it does work, `KVOTitle` often times fires a change many times repeatedly for a single navigation (tested on YouTube). So, I have concerns with performance with that approach especially since there may be web content out there that abuses `document.title`. Neither approach is particularly "great", but I feel that there is less complexity and lower potential performance implications with this PR. If you have any other suggestions though, I'd be glad to hear them :-)

Comment 6

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/b3b12590bebb48a35c827943fd063cc8d113fb15

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on master b3b12590b. The youtube videos are displayed in the history list.