1360123 - Move all ConstructMediaTracks()/RemoveMediaTracks() logics from MediaDecoder to HTMLMediaElemnt.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Tzuhao Kuo [:kaku]]

Spawn from bug 1348432 comment 6 and bug 1348432 comment 19.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1360123 P1 - don't bother creating a new track list in HTMLMediaElement::RemoveMediaTracks()

Review commit: https://reviewboard.mozilla.org/r/134222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134222/

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1360123 P2 - move ConstructMediaTracks/RemoveMediaTracks to HTMLMediaElemnt;

Review commit: https://reviewboard.mozilla.org/r/134224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134224/

Comment 3

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1360123 P3 - while shutting down a MediaDecoder, ask its owner to remove all media tracks;

Review commit: https://reviewboard.mozilla.org/r/134226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134226/

Comment 4

[Tzuhao Kuo [:kaku]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86af96bc4f802bddb70a11cf905ed8443b751ae7
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c7508e88e99b7a0ba49f8d0efb913bec121e9dd

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8862300 [details]
Bug 1360123 P1 - don't bother creating a new track list in HTMLMediaElement::RemoveMediaTracks()

https://reviewboard.mozilla.org/r/134222/#review137202

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8862301 [details]
Bug 1360123 P2 - move ConstructMediaTracks/RemoveMediaTracks to HTMLMediaElemnt;

https://reviewboard.mozilla.org/r/134224/#review137204

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8862302 [details]
Bug 1360123 P3 - while shutting down a MediaDecoder, ask its owner to remove all media tracks;

https://reviewboard.mozilla.org/r/134226/#review137206

Comment 8

[Tzuhao Kuo [:kaku]]

Try looks good, thanks for the review!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fda11f98f80
P1 - don't bother creating a new track list in HTMLMediaElement::RemoveMediaTracks() r=jwwang
https://hg.mozilla.org/integration/autoland/rev/ba42f98ee794
P2 - move ConstructMediaTracks/RemoveMediaTracks to HTMLMediaElemnt; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/4cd16948b4a4
P3 - while shutting down a MediaDecoder, ask its owner to remove all media tracks; r=jwwang

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5fda11f98f80
https://hg.mozilla.org/mozilla-central/rev/ba42f98ee794
https://hg.mozilla.org/mozilla-central/rev/4cd16948b4a4