The default bug view has changed. See this FAQ.

Missing audio in YouTube videos that were requested within the same tab. Refreshing page fixes audio.

ASSIGNED
Assigned to

Status

()

Core
Audio/Video: Playback
P1
normal
ASSIGNED
6 days ago
35 minutes ago

People

(Reporter: smartfon.reddit, Assigned: kaku)

Tracking

({leave-open, regression})

55 Branch
leave-open, regression
Points:
---

Firefox Tracking Flags

(firefox54 unaffected, firefox55 affected)

Details

(Whiteboard: [webcompat])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 days ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170317111607

Steps to reproduce:

Visit YouTube and play any video. It plays fine. Click to play another video.


Actual results:

That, and all future videos play without audio, unless the page is refreshed. The page must be refreshed for every new video. Started after 2017-03-17 Nightly. Most likely after the second (~2PM PST) update - not the morning one. Tested with new profile. Not related to YouTube mute button.


Expected results:

You should be able to request a video in the same tab without having to refresh the tab, to play the audio.

Updated

6 days ago
Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

Comment 1

6 days ago
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aecbad803701a0d8eab8bad19348df37dcb42435&tochange=23cfb067130f6225f9b63c752c349fd607e69c46

Regressed by: Bug 1347402
Blocks: 1347402
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Ever confirmed: true
Flags: needinfo?(kaku)
Keywords: regression
(Assignee)

Updated

5 days ago
Assignee: nobody → kaku
Status: NEW → ASSIGNED
Flags: needinfo?(kaku)
(Assignee)

Comment 2

5 days ago
Thanks for reporting this regression in quickly!

The root cause is that we moved MediaDecoder::ConstructMediaTracks() , MediaDecoder::RemoveMediaTracks(), and MediaDecoder::mMediaTracksConstructed (which is a boolean) into HTMLMediaElement in bug 1347402 patch 4. It's fine to the two methods but not right to the MediaDecoder::mMediaTracksConstructed flag. This flag should belong to a MediaDecoder, every time a HTMLMediaElement switches its MediaDecoder, the flag should be reset to false again. 

So, we have two solutions to this bug:
(1) Keep the flag in the HTMLMediaElement and reset it while shouting down a decoder.
(2) Keep the flag in the MediaDecoder and it will be initialized to be false while we have a new MediaDecoder.

I think the 2nd proposal is better since it won't mess up the code in HTMLMediaElement::ShutdownDecoder().
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 4

5 days ago
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f7df09912faab115655284ba73e794781ea7461
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2877f3bf6e35fb0c895475917b657187a7d1f12a

Updated

4 days ago
Duplicate of this bug: 1348692

Comment 6

4 days ago
mozreview-review
Comment on attachment 8848831 [details]
Bug 1348432 - move the mMediaTracksConstructed flag back to MediaDecoder;

https://reviewboard.mozilla.org/r/121708/#review123776

It is a bad smell that MediaDecoder shows too much interest in HTMLMediaElement's properties because it breaks encapsulation. I think the issue can be resolved by calling GetOwner()->RemoveMediaTracks() in MediaDecoder::Shutdown().
Attachment #8848831 - Flags: review?(jwwang) → review-
(Assignee)

Comment 7

4 days ago
mozreview-review-reply
Comment on attachment 8848831 [details]
Bug 1348432 - move the mMediaTracksConstructed flag back to MediaDecoder;

https://reviewboard.mozilla.org/r/121708/#review123776

Good idea, will do it.
Comment hidden (mozreview-request)
(Assignee)

Updated

4 days ago
Attachment #8848831 - Attachment is obsolete: true
(Assignee)

Comment 9

4 days ago
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba0f5c924e223558483b445d3889b44809c60438
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4fbc6ebe4c98476c3ebd1e2ab6415f1bebe2025

Comment 10

3 days ago
mozreview-review
Comment on attachment 8848968 [details]
Bug 1348432 - while shutting down a MediaDecoder, ask its owner to remove all media tracks;

https://reviewboard.mozilla.org/r/121814/#review123782
Attachment #8848968 - Flags: review?(jwwang) → review+
Duplicate of this bug: 1348734
Whiteboard: [webcompat]

Comment 12

3 days ago
I've got this bug too. Sound doesn't work more or less 1 time each 3 videos with automatic play switch "on". I don't have a strict str.

browser:      Nightly 55.0a1 (2017-03-19) (64 bits)
OS:           Windows 10
hd:           SSD Crucial 256 GO
graphic card: NVIDIA GeForce GTX 960

Updated

3 days ago
Duplicate of this bug: 1348831

Comment 14

3 days ago
This isn't just YouTube, it also happens for me on the Steam store when attempting to put a trailer in fullscreen.

Updated

3 days ago
Duplicate of this bug: 1348933

Updated

3 days ago
Duplicate of this bug: 1349001

Comment 17

3 days ago
This problem also occurs when new content is loaded by the user within a page (without loading), for example when playing two videos in a row on Facebook or listen to two tracks in a row on VK.

Updated

2 days ago
Duplicate of this bug: 1349325
(Assignee)

Comment 19

2 days ago
(In reply to Tzuhao Kuo [:kaku] from comment #9)
> Try:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba0f5c924e223558483b445d3889b44809c60438
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4fbc6ebe4c98476c3ebd1e2ab6415f1bebe2025

Try looks very crazy, and I am not able to figure it out in a short period, so, I would like to land attachment 8848831 [details] at this moment as a workaround. Attachment 8848831 [details] is kind of reverting the root cause of this bug which was introduced at bug 1347402 patch 4. 

Will upload a new patch soon.
(Assignee)

Updated

2 days ago
Keywords: leave-open
Comment hidden (mozreview-request)
(Assignee)

Updated

a day ago
Attachment #8848968 - Attachment is obsolete: true
(Assignee)

Comment 21

a day ago
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2823d84b2693074edc08c106bfbf0f58d9f749cc
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d9df7e78a54dbc0ac512cbf344aa0f943e02d00

Comment 22

a day ago
mozreview-review
Comment on attachment 8849824 [details]
Bug 1348432 - move the mMediaTracksConstructed flag back to MediaDecoder;

https://reviewboard.mozilla.org/r/122570/#review124760
Attachment #8849824 - Flags: review?(jwwang) → review+
(Assignee)

Comment 23

a day ago
Try looks good, thanks for the review!
Keywords: checkin-needed

Comment 24

a day ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c979d49bdbc5
move the mMediaTracksConstructed flag back to MediaDecoder; r=jwwang
Keywords: checkin-needed

Comment 25

a day ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c979d49bdbc5
Duplicate of this bug: 1349331

Updated

22 hours ago
Duplicate of this bug: 1349619
Duplicate of this bug: 1349783

Comment 29

an hour ago
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
BuildID: 20170323030203

Bug seems to be fixed in the new Nightly Build.

Thank you very much :)

Comment 30

38 minutes ago
My reproducible ways to this bug (on other websites than youtube when changing the video quality) are no longer working. Audio is now working as expected. Thank you ;-)

Comment 31

35 minutes ago
(In reply to bugzilla from comment #30)
> My reproducible ways to this bug (on other websites than youtube when
> changing the video quality) are no longer working. Audio is now working as
> expected. Thank you ;-)

Sorry, I've forgotten: I am using BuildID: 20170323110205 @ Debian testing = Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
You need to log in before you can comment on or make changes to this bug.