1360133 - stylo: Make {stop, flood}-opacity animatable

Status: RESOLVED FIXED

Description

[Jeremy Chen [:jeremychen] UTC+8]

There are still bunch of SVG related properties not animatable yet (see 1353918 comment 2). Per discussed with Boris offline, it would be great if we could have someone start to take care of this. I think we could start with some basic types, e.g., <number>, <color>, ..., to see if they could work for SVG as well.

Since I might have some cycles to work on high-priority stuff, I'll start with fill-opacity first. I believe this could be an example for other xxx-opacity properties.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I think this is the easiest one. We should do other -opacity properties in this bug too.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Actually I did enable this in bug 1336772 comment 3.

Comment 3

[Jeremy Chen [:jeremychen] UTC+8]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> Actually I did enable this in bug 1336772 comment 3.

Oops, so I guess you'll take care of all the -opacity properties there as well?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

No, I will not.  But I think this one is too easy for you. :-)

Comment 5

[Boris Chiou [:boris]]

Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset) or {*}-color (e.g. flood-color)?

Comment 6

[Jeremy Chen [:jeremychen] UTC+8]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> No, I will not.  But I think this one is too easy for you. :-)

Alright, then I guess I should find some other not-too-easy bugs...

Oh, and we shall rename this bug for making other *-opacity properties animatable.

(In reply to Boris Chiou [:boris] from comment #5)
> Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset)
> or {*}-color (e.g. flood-color)?

Sounds good.
Since *-opacity properties are not all animatable yet, I think we shall keep this bug with proper summary fixed.
I'll file a separate bug for stroke-{*}

Comment 7

[Jeremy Chen [:jeremychen] UTC+8]

Un-take this bug per comment 4.

Comment 8

[Boris Chiou [:boris]]

Jeremy, this bug blocks test_transitions_per_property.html. Are you still interested in this bug? Thanks.

Comment 9

[Jeremy Chen [:jeremychen] UTC+8]

(In reply to Boris Chiou [:boris] (away 6/9~6/12) from comment #8)
> Jeremy, this bug blocks test_transitions_per_property.html. Are you still
> interested in this bug? Thanks.

Sure, this should be straightforward since I already added WPT tests for Opacity type in Bug 1360144.

Comment 10

[Brian Birtles (:birtles)]

You might want to fix bug 1369624 (fill-opacity) at the same time.

Comment 11

[Jeremy Chen [:jeremychen] UTC+8]

Created attachment 8875993 [details]
Bug 1360133 - stylo: make {stop, flood}-opacity animatable.

Review commit: https://reviewboard.mozilla.org/r/147408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147408/

Comment 12

[Jeremy Chen [:jeremychen] UTC+8]

Created attachment 8875994 [details]
Bug 1360133 - enable WPT interpolation tests for SVG {stop, flood}-opacity.

Review commit: https://reviewboard.mozilla.org/r/147410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147410/

Comment 13

[Jeremy Chen [:jeremychen] UTC+8]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c

Let's see if I break (or fix) anything before asking for review.

Comment 14

[Jeremy Chen [:jeremychen] UTC+8]

(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> 
> Let's see if I break (or fix) anything before asking for review.

try looks fine, but there's no unexpected pass shown.
I guess either we test them in dom/smil/test/ or in web-platform-tests, and neither of them is enabled yet.

Ask for review then.

Comment 15

[Hiroyuki Ikezoe (:hiro)]

(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #14)
> (In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> > https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> > 
> > Let's see if I break (or fix) anything before asking for review.
> 
> try looks fine, but there's no unexpected pass shown.
> I guess either we test them in dom/smil/test/ or in web-platform-tests, and
> neither of them is enabled yet.
> 
> Ask for review then.

dom/smil/test/test_smilMappedAttrFromTo.xhtml and dom/smil/test/test_smilCSSFromTo.xhtml.

See https://docs.google.com/spreadsheets/d/1iDkLyj06ZnAFynoIRW8uawZsHNS7Fl_ZTO7sbqUDkTE/edit#gid=1420354661

Comment 16

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8875993 [details]
Bug 1360133 - stylo: make {stop, flood}-opacity animatable.

https://reviewboard.mozilla.org/r/147408/#review151678

Comment 17

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8875994 [details]
Bug 1360133 - enable WPT interpolation tests for SVG {stop, flood}-opacity.

https://reviewboard.mozilla.org/r/147410/#review151680

Comment 18

[Jeremy Chen [:jeremychen] UTC+8]

servo PR: https://github.com/servo/servo/pull/17251

Comment 19

[Jeremy Chen [:jeremychen] UTC+8]

Comment on attachment 8875994 [details]
Bug 1360133 - enable WPT interpolation tests for SVG {stop, flood}-opacity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147410/diff/1-2/

Comment 20

[Jeremy Chen [:jeremychen] UTC+8]

servo part merged: https://hg.mozilla.org/integration/autoland/rev/3888304a47f3

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d3603a87085
enable WPT interpolation tests for SVG {stop, flood}-opacity. r=hiro

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d3603a87085