Closed Bug 1360133 Opened 3 years ago Closed 3 years ago

stylo: Make {stop, flood}-opacity animatable

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: chenpighead, Assigned: chenpighead)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

There are still bunch of SVG related properties not animatable yet (see 1353918 comment 2). Per discussed with Boris offline, it would be great if we could have someone start to take care of this. I think we could start with some basic types, e.g., <number>, <color>, ..., to see if they could work for SVG as well.

Since I might have some cycles to work on high-priority stuff, I'll start with fill-opacity first. I believe this could be an example for other xxx-opacity properties.
Priority: -- → P2
I think this is the easiest one. We should do other -opacity properties in this bug too.
Actually I did enable this in bug 1336772 comment 3.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> Actually I did enable this in bug 1336772 comment 3.

Oops, so I guess you'll take care of all the -opacity properties there as well?
Flags: needinfo?(hikezoe)
No, I will not.  But I think this one is too easy for you. :-)
Flags: needinfo?(hikezoe)
Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset) or {*}-color (e.g. flood-color)?
(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> No, I will not.  But I think this one is too easy for you. :-)

Alright, then I guess I should find some other not-too-easy bugs...

Oh, and we shall rename this bug for making other *-opacity properties animatable.

(In reply to Boris Chiou [:boris] from comment #5)
> Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset)
> or {*}-color (e.g. flood-color)?

Sounds good.
Since *-opacity properties are not all animatable yet, I think we shall keep this bug with proper summary fixed.
I'll file a separate bug for stroke-{*}
Summary: stylo: Make fill-opacity animatable → stylo: Make {stop, flood}-opacity animatable
Un-take this bug per comment 4.
Assignee: jeremychen → nobody
Status: ASSIGNED → NEW
No longer blocks: 1353918
Blocks: 1353918
Blocks: 1292283
Priority: P2 → P1
Jeremy, this bug blocks test_transitions_per_property.html. Are you still interested in this bug? Thanks.
Flags: needinfo?(jeremychen)
(In reply to Boris Chiou [:boris] (away 6/9~6/12) from comment #8)
> Jeremy, this bug blocks test_transitions_per_property.html. Are you still
> interested in this bug? Thanks.

Sure, this should be straightforward since I already added WPT tests for Opacity type in Bug 1360144.
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
Flags: needinfo?(jeremychen)
You might want to fix bug 1369624 (fill-opacity) at the same time.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c

Let's see if I break (or fix) anything before asking for review.
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> 
> Let's see if I break (or fix) anything before asking for review.

try looks fine, but there's no unexpected pass shown.
I guess either we test them in dom/smil/test/ or in web-platform-tests, and neither of them is enabled yet.

Ask for review then.
Attachment #8875993 - Flags: review?(hikezoe)
Attachment #8875994 - Flags: review?(hikezoe)
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #14)
> (In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> > https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> > 
> > Let's see if I break (or fix) anything before asking for review.
> 
> try looks fine, but there's no unexpected pass shown.
> I guess either we test them in dom/smil/test/ or in web-platform-tests, and
> neither of them is enabled yet.
> 
> Ask for review then.

dom/smil/test/test_smilMappedAttrFromTo.xhtml and dom/smil/test/test_smilCSSFromTo.xhtml.

See https://docs.google.com/spreadsheets/d/1iDkLyj06ZnAFynoIRW8uawZsHNS7Fl_ZTO7sbqUDkTE/edit#gid=1420354661
Comment on attachment 8875993 [details]
Bug 1360133 - stylo: make {stop, flood}-opacity animatable.

https://reviewboard.mozilla.org/r/147408/#review151678
Attachment #8875993 - Flags: review?(hikezoe) → review+
Comment on attachment 8875994 [details]
Bug 1360133 - enable WPT interpolation tests for SVG {stop, flood}-opacity.

https://reviewboard.mozilla.org/r/147410/#review151680
Attachment #8875994 - Flags: review?(hikezoe) → review+
Attachment #8875993 - Attachment is obsolete: true
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d3603a87085
enable WPT interpolation tests for SVG {stop, flood}-opacity. r=hiro
https://hg.mozilla.org/mozilla-central/rev/6d3603a87085
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.