stylo: Make {stop, flood}-opacity animatable

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

(Blocks: 4 bugs)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 months ago
There are still bunch of SVG related properties not animatable yet (see 1353918 comment 2). Per discussed with Boris offline, it would be great if we could have someone start to take care of this. I think we could start with some basic types, e.g., <number>, <color>, ..., to see if they could work for SVG as well.

Since I might have some cycles to work on high-priority stuff, I'll start with fill-opacity first. I believe this could be an example for other xxx-opacity properties.

Updated

3 months ago
Priority: -- → P2
I think this is the easiest one. We should do other -opacity properties in this bug too.
Actually I did enable this in bug 1336772 comment 3.
(Assignee)

Comment 3

3 months ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> Actually I did enable this in bug 1336772 comment 3.

Oops, so I guess you'll take care of all the -opacity properties there as well?
Flags: needinfo?(hikezoe)
No, I will not.  But I think this one is too easy for you. :-)
Flags: needinfo?(hikezoe)

Comment 5

3 months ago
Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset) or {*}-color (e.g. flood-color)?
(Assignee)

Comment 6

3 months ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> No, I will not.  But I think this one is too easy for you. :-)

Alright, then I guess I should find some other not-too-easy bugs...

Oh, and we shall rename this bug for making other *-opacity properties animatable.

(In reply to Boris Chiou [:boris] from comment #5)
> Jeremy, would you like to change this bug to stroke-{*} (e.g. stroke-offset)
> or {*}-color (e.g. flood-color)?

Sounds good.
Since *-opacity properties are not all animatable yet, I think we shall keep this bug with proper summary fixed.
I'll file a separate bug for stroke-{*}
Summary: stylo: Make fill-opacity animatable → stylo: Make {stop, flood}-opacity animatable
(Assignee)

Comment 7

3 months ago
Un-take this bug per comment 4.
Assignee: jeremychen → nobody
Status: ASSIGNED → NEW

Updated

3 months ago
No longer blocks: 1353918

Updated

3 months ago
Blocks: 1353918
Blocks: 1302948

Updated

2 months ago
Blocks: 1292283

Updated

2 months ago
Priority: P2 → P1

Comment 8

2 months ago
Jeremy, this bug blocks test_transitions_per_property.html. Are you still interested in this bug? Thanks.
Flags: needinfo?(jeremychen)
(Assignee)

Comment 9

2 months ago
(In reply to Boris Chiou [:boris] (away 6/9~6/12) from comment #8)
> Jeremy, this bug blocks test_transitions_per_property.html. Are you still
> interested in this bug? Thanks.

Sure, this should be straightforward since I already added WPT tests for Opacity type in Bug 1360144.
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
Flags: needinfo?(jeremychen)
You might want to fix bug 1369624 (fill-opacity) at the same time.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 13

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c

Let's see if I break (or fix) anything before asking for review.
(Assignee)

Comment 14

2 months ago
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> 
> Let's see if I break (or fix) anything before asking for review.

try looks fine, but there's no unexpected pass shown.
I guess either we test them in dom/smil/test/ or in web-platform-tests, and neither of them is enabled yet.

Ask for review then.
(Assignee)

Updated

2 months ago
Attachment #8875993 - Flags: review?(hikezoe)
Attachment #8875994 - Flags: review?(hikezoe)
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #14)
> (In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #13)
> > https://treeherder.mozilla.org/#/jobs?repo=try&revision=038cff49f54c
> > 
> > Let's see if I break (or fix) anything before asking for review.
> 
> try looks fine, but there's no unexpected pass shown.
> I guess either we test them in dom/smil/test/ or in web-platform-tests, and
> neither of them is enabled yet.
> 
> Ask for review then.

dom/smil/test/test_smilMappedAttrFromTo.xhtml and dom/smil/test/test_smilCSSFromTo.xhtml.

See https://docs.google.com/spreadsheets/d/1iDkLyj06ZnAFynoIRW8uawZsHNS7Fl_ZTO7sbqUDkTE/edit#gid=1420354661

Comment 16

2 months ago
mozreview-review
Comment on attachment 8875993 [details]
Bug 1360133 - stylo: make {stop, flood}-opacity animatable.

https://reviewboard.mozilla.org/r/147408/#review151678
Attachment #8875993 - Flags: review?(hikezoe) → review+

Comment 17

2 months ago
mozreview-review
Comment on attachment 8875994 [details]
Bug 1360133 - enable WPT interpolation tests for SVG {stop, flood}-opacity.

https://reviewboard.mozilla.org/r/147410/#review151680
Attachment #8875994 - Flags: review?(hikezoe) → review+
(Assignee)

Comment 18

2 months ago
servo PR: https://github.com/servo/servo/pull/17251
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8875993 - Attachment is obsolete: true
(Assignee)

Comment 20

2 months ago
servo part merged: https://hg.mozilla.org/integration/autoland/rev/3888304a47f3

Comment 21

2 months ago
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d3603a87085
enable WPT interpolation tests for SVG {stop, flood}-opacity. r=hiro

Comment 22

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d3603a87085
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.