Closed Bug 1369624 Opened 2 years ago Closed 2 years ago

stylo: fill-opacity should be animatable

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: birtles, Assigned: jeremychen)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Oddly, stroke-opacity already is.
Blocks: 1292283
Priority: -- → P1
Per bug 1360133 comment 10, assign to myself.
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
I suspect (hope) you'll need to mark the following tests as passing:

layout/reftests/svg/smil/anim-fillopacity-1none.svg
layout/reftests/svg/smil/anim-fillopacity-1css.svg
layout/reftests/svg/smil/anim-fillopacity-1xml.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-1-by.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-1-from-by.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-1-from-to.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-1-to.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-2-paced.svg
layout/reftests/svg/smil/style/anim-css-fillopacity-3-clamp-small.svg
(In reply to Brian Birtles (:birtles) from comment #4)
> I suspect (hope) you'll need to mark the following tests as passing:
> 
> layout/reftests/svg/smil/anim-fillopacity-1none.svg
> layout/reftests/svg/smil/anim-fillopacity-1css.svg
> layout/reftests/svg/smil/anim-fillopacity-1xml.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-1-by.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-1-from-by.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-1-from-to.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-1-to.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-2-paced.svg
> layout/reftests/svg/smil/style/anim-css-fillopacity-3-clamp-small.svg

Nice, I just pushed a try to see if I could find some unexpected-pass.
I'll ask for review once I get the test expectation udpate part ready.
Looks like the transition works fine for SVG fill-opacity with stylo.
Attachment #8875540 - Flags: review?(boris.chiou)
Attachment #8875541 - Flags: review?(boris.chiou)
Attachment #8875589 - Flags: review?(boris.chiou)
Attachment #8875590 - Flags: review?(boris.chiou)
Comment on attachment 8875590 [details]
Bug 1369624 - stylo: update test expectations for animation support of SVG fill-opacity.

https://reviewboard.mozilla.org/r/147010/#review151130
Attachment #8875590 - Flags: review?(boris.chiou) → review+
Comment on attachment 8875541 [details]
Bug 1369624 - enable WPT interpolation tests for SVG fill-opacity.

https://reviewboard.mozilla.org/r/146968/#review151132
Attachment #8875541 - Flags: review?(boris.chiou) → review+
Comment on attachment 8875589 [details]
Bug 1369624 - update manifest for WPT.

https://reviewboard.mozilla.org/r/147008/#review151134
Attachment #8875589 - Flags: review?(boris.chiou) → review+
Comment on attachment 8875540 [details]
Bug 1369624 - stylo: make fill-opacity animatable.

https://reviewboard.mozilla.org/r/146966/#review151136
Attachment #8875540 - Flags: review?(boris.chiou) → review+
Attachment #8875540 - Attachment is obsolete: true
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 337ec4205f26 -d 1961976dc596: rebasing 400834:337ec4205f26 "Bug 1369624 - enable WPT interpolation tests for SVG fill-opacity. r=boris"
rebasing 400835:a27248075681 "Bug 1369624 - update manifest for WPT. r=boris"
merging testing/web-platform/meta/MANIFEST.json
warning: conflicts while merging testing/web-platform/meta/MANIFEST.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4606d8c6c6c
enable WPT interpolation tests for SVG fill-opacity.
https://hg.mozilla.org/integration/autoland/rev/772e8e39e74d
update manifest for WPT.
https://hg.mozilla.org/integration/autoland/rev/09251a0a6771
stylo: update test expectations for animation support of SVG fill-opacity.
https://hg.mozilla.org/mozilla-central/rev/e4606d8c6c6c
https://hg.mozilla.org/mozilla-central/rev/772e8e39e74d
https://hg.mozilla.org/mozilla-central/rev/09251a0a6771
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.