136017 - Some characters in menus/dialogs/etc. are rendered incorrectly

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Marek Wawoczny]

Some characters in menus/dialogs/etc. are rendered incorrectly, see attached screenshot - on left build 20020405, on right 20020406 (incorectly rendered chars are marked with red dot). This is probably regression caused by:
http://bugzilla.mozilla.org/show_bug.cgi?id=134733
http://bugzilla.mozilla.org/show_bug.cgi?id=86532

Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:0.9.9+) Gecko/20020406

Comment 1

[Marek Wawoczny]

Attachment: Screenshot - build 20020405 and 20020406

Comment 2

[Roy Yokoyama]

marek:  thank you very much for your screen attachment. It's really helpful. :)

shanjian: I don't think it's a localization problem. (correct me I am wrong); but
          it looks more like a layout problem ( chars are touching the adjacent
chars and
          char height are different. )  Any clues for recent changes in the tree?

Comment 3

[Shanjian Li]

this looks like a side-effect caused by bug 134733. I didn't expect truetype
font looks so poorly. We could fix this problem by treating certain charset
differently. But this reason might not be strong enough to back out my patch for
that bug.  

Comment 4

[Marek Wawoczny]

Seems that adding user_pref("font.default", "sans-serif"); to prefs.js in user profile fixes about 80-90% cases.
Could this be nominated for 1.0?

Comment 5

[Marek Wawoczny]

Attachment: Testcase

Comment 6

[Marek Wawoczny]

Adding keyword: patch regression

Attaching patch, which fixes issues with Polish and Czech characters, also attaching screenshoot before and after applying patch.

Comment 7

[Marek Wawoczny]

Attachment: Patch which fixes issues with Polish and Czech characters

Comment 8

[Marek Wawoczny]

Attachment: Screenshot before and after patch

Comment 9

[Shanjian Li]

Marek, you might want to check argument "nsCharsetInfo* aSelf", only when 
aSelf->mCodePage indicate it is Polish or Czech, should we apply your patch. 

Comment 10

[rchen]

shanjian, can you take over this?

Comment 11

[Frank Tang]

so... only 4 characters have problem (and all in 0x80-0x9f range,right ?)

Comment 12

[Frank Tang]

I am wrong- 9 chars.

Comment 13

[Marek Wawoczny]

Something like:
  if (aSelf->mCodePage == 1250) {
    mb[138] = 138;
    mb[140] = 140;
    mb[141] = 141;
    mb[142] = 142;
    mb[143] = 143;
    mb[154] = 154;
    mb[156] = 156;
    mb[158] = 158;
    mb[159] = 159;
  }

But this is only for Windows-1250, I should also add ISO-8859-2, but I don't
known mCodePage for it, anyone can help?

Comment 14

[Marek Wawoczny]

Btw. I don't know if only this 9 chars are wrong, we should check _all_ characters. 
I've already checked Polish, Czech and German - German chars were fine.

Comment 15

[Shanjian Li]

Yes, that's what we need.
Don't worry about latin-2, it is not a window ACP code page. 
Just make sure win1250 works fine and we can check in your patch. 

Comment 16

[Marek Wawoczny]

Attachment: Updated patch which fixes issues with Polish and Czech characters

Comment 17

[Shanjian Li]

Comment on attachment 82006 [details] [diff] [review]
Updated patch which fixes issues with Polish and Czech characters

r=shanjian

Comment 18

[Shanjian Li]

attinasi, could you sr?

Comment 19

[Marek Wawoczny]

Status Whiteboard:[FIX IN HAND][need sr=]

Comment 20

[Shanjian Li]

chris, could you sr?

Comment 21

[Marek Wawoczny]

This really need to be in 1.0...
Anyone can sr=?

Comment 22

[Shanjian Li]

chris, could you sr?

Comment 23

[Chris Waterson]

Comment on attachment 82006 [details] [diff] [review]
Updated patch which fixes issues with Polish and Czech characters

sr=waterson

Comment 24

[Marek Wawoczny]

Nominating for mozilla1.0.1, for 1.0 is too late (?)

Comment 25

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Check this into the trunk before getting 1.0.1 approval.

Comment 26

[Marek Wawoczny]

Anyone can check this into trunk, please?

Comment 27

[Shanjian Li]

I just checked it into trunk. Mark it as fixed.
Add nsbeta1 to keyword for consideration of nsbeta1

Comment 28

[Ivan Sagalaev]

Is this bug related only to certain Polish and Czech characters? I'm asking
because there's a pretty same problem with one russian letter (#255 ASCII). At
least on Windows as far as I can see.

Comment 29

[Ivan Sagalaev]

Attachment: Wrongly displayed russian character

A screenshot for my previous post.

Comment 30

[Shanjian Li]

If it is a problem, it should be a different one. Open a new bug and let's do
some investigation. 

Comment 31

[Ivan Sagalaev]

Filed a new bug 148984. Thank you for assistance.

Comment 32

[Judson Valeski]

"please land this on the 1.0.1 branch. once there remove the "mozilla1.0.1+"
keyword, and add the "fixed1.0.1"

Comment 33

[Marek Wawoczny]

Shanjian Li:
Could you check this into branch, please?

Comment 34

[Shanjian Li]

patch checked into branch. 

Comment 35

[Yuying Long]

Verified the test case in comment #5 is displayed fine with charset set to
iso-8859-2 on 06-12 branch build on WinXP.

Comment 36

[Teruko Kobayashi]

Verified in 8-23 1.0.1 branch build.