1360357 - Inline sourcemap is causing request for resource.

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P2)

Description

[mastrauckas]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170418004027

Steps to reproduce:

Have an inline sourcemap in a javascript file as example: sourceMappingURL=data:application/json;charset=utf-8;base64,<sourcemap>
In the html file add script file that points to javascript file with inline source map.
Call html file.



Actual results:

When loading page it made a call to get sourcemap file which causes a http 404.


Expected results:

Since its a inline source file I expect it not to make a call for sourcemap file.

Comment 1

[Tom Tromey :tromey]

The bug here is that the definition of isURL in source-maps is incorrect.
https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-source-map/src/path.js#L12-L14
In particular it doesn't recognize data: URLs.

Comment 2

[Tom Tromey :tromey]

See https://github.com/devtools-html/devtools-core/pull/371
After that, and the follow-up to bump the revision, I'll land it in M-C.

Comment 4

[Tom Tromey :tromey]

I plan to add a new integration test here, so not marking as a dup of the devtools-source-map bug.

Comment 5

[Tom Tromey :tromey]

Attachment: Bug 1360357 - add test for inline source maps;

Review commit: https://reviewboard.mozilla.org/r/139822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139822/

Comment 6

[Tom Tromey :tromey]

New version will use some stuff introduced in the other bug.

Comment 7

[Tom Tromey :tromey]

Comment on attachment 8868245 [details]
Bug 1360357 - add test for inline source maps;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139822/diff/1-2/

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8868245 [details]
Bug 1360357 - add test for inline source maps;

https://reviewboard.mozilla.org/r/139822/#review143218

Thanks for adding the test!

::: devtools/client/framework/test/code_inline_original.js:6
(Diff revision 2)
> +/* Any copyright is dedicated to the Public Domain.
> + http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +// Original source code for the inline source map test.
> +// The generated file was made with
> +//    webpack --devtool inline-source-map code_inline_original.js code_inline_bundle.js

thanks for including that comment :)

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4075c099444c -d 3885392de7d9: rebasing 396281:4075c099444c "Bug 1360357 - add test for inline source maps; r=jdescottes" (tip)
merging devtools/client/framework/test/browser.ini
warning: conflicts while merging devtools/client/framework/test/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Tom Tromey :tromey]

Comment on attachment 8868245 [details]
Bug 1360357 - add test for inline source maps;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139822/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/495ed740cb70
add test for inline source maps; r=jdescottes

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/495ed740cb70