Closed
Bug 1360443
Opened 7 years ago
Closed 7 years ago
Write test for display of embedded cid: images with crossorigin="anonymous"
Categories
(Thunderbird :: Message Compose Window, enhancement)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: jorgk-bmo, Assigned: aceman)
Details
Attachments
(1 file, 3 obsolete files)
5.16 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1352701 +++
Since bug 1347598 was fixed, TB can also display an image like this:
<img crossorigin="anonymous" src="cid:7c1c11e9-e067-492a-bc60-32cf380c219f">
We should add a few lines to mail/test/mozmill/composition/test-image-display.js to cover this.
Flags: needinfo?(acelists)
OK, what is to test here? Just that such an image displays? Did the attribute somehow prevent it from displaying?
Flags: needinfo?(acelists)
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to :aceman from comment #1)
> Just that such an image displays?
Exactly.
> Did the attribute somehow prevent it from displaying?
Exactly. And it needed this much code (and 74 comments and various experts) to fix that ;-) (bug 1347598):
https://hg.mozilla.org/comm-central/rev/291bc010edbf0fcc00600201fef1da7865555bc3
Like this?
Reporter | ||
Comment 4•7 years ago
|
||
(In reply to :aceman from comment #3)
> Like this?
Yes, thanks. In principal, but perhaps more like this ;-)
Attachment #8867503 -
Flags: review+
Attachment #8867503 -
Flags: feedback?(acelists)
Reporter | ||
Updated•7 years ago
|
Attachment #8867501 -
Flags: review?(jorgk)
Comment on attachment 8867503 [details] [diff] [review]
1360443.patch (v2).
Review of attachment 8867503 [details] [diff] [review]:
-----------------------------------------------------------------
OK, if you want to check all the cases :)
::: mail/test/mozmill/composition/test-image-display.js
@@ +31,5 @@
>
> /**
> * Check dimensions of the embedded image and whether it could be loaded.
> */
> +function check_image_size(aController, aImage, aID, aSrcStart) {
You pass no aID from the callers.
Reporter | ||
Comment 6•7 years ago
|
||
(In reply to :aceman from comment #5)
> You pass no aID from the callers.
Damn. However, the test passed ;-)
Attachment #8867501 -
Attachment is obsolete: true
Attachment #8867503 -
Attachment is obsolete: true
Attachment #8867503 -
Flags: feedback?(acelists)
Attachment #8867508 -
Flags: review+
Attachment #8867508 -
Flags: feedback?(acelists)
Comment on attachment 8867508 [details] [diff] [review]
1360443.patch (v2b).
Review of attachment 8867508 [details] [diff] [review]:
-----------------------------------------------------------------
::: mail/test/mozmill/composition/test-image-display.js
@@ +31,5 @@
>
> /**
> * Check dimensions of the embedded image and whether it could be loaded.
> */
> +function check_image_size(aController, aImage, aID, aSrcStart) {
In the current set of tests, you could just use aImage.id . Or do you prepare this function for passing in elements without id? Even in that case showing no ID would be fine.
Reporter | ||
Comment 8•7 years ago
|
||
I should have let you do it ;-(
Attachment #8867508 -
Attachment is obsolete: true
Attachment #8867508 -
Flags: feedback?(acelists)
Attachment #8867510 -
Flags: review?(acelists)
Comment on attachment 8867510 [details] [diff] [review]
1360443.patch (v2c).
Review of attachment 8867510 [details] [diff] [review]:
-----------------------------------------------------------------
OK now :)
Attachment #8867510 -
Flags: review?(acelists) → review+
Reporter | ||
Comment 10•7 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in
before you can comment on or make changes to this bug.
Description
•