1360443 - Write test for display of embedded cid: images with crossorigin="anonymous"

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1352701 +++

Since bug 1347598 was fixed, TB can also display an image like this:
<img crossorigin="anonymous" src="cid:7c1c11e9-e067-492a-bc60-32cf380c219f">

We should add a few lines to mail/test/mozmill/composition/test-image-display.js to cover this.

Comment 1

[:aceman]

OK, what is to test here? Just that such an image displays? Did the attribute somehow prevent it from displaying?

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #1)
> Just that such an image displays?
Exactly.

> Did the attribute somehow prevent it from displaying?
Exactly. And it needed this much code (and 74 comments and various experts) to fix that ;-) (bug 1347598):
https://hg.mozilla.org/comm-central/rev/291bc010edbf0fcc00600201fef1da7865555bc3

Comment 3

[:aceman]

Attachment: patch

Like this?

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1360443.patch (v2).

(In reply to :aceman from comment #3)
> Like this?
Yes, thanks. In principal, but perhaps more like this ;-)

Comment 5

[:aceman]

Comment on attachment 8867503 [details] [diff] [review]
1360443.patch (v2).

Review of attachment 8867503 [details] [diff] [review]:
-----------------------------------------------------------------

OK, if you want to check all the cases :)

::: mail/test/mozmill/composition/test-image-display.js
@@ +31,5 @@
>  
>  /**
>   * Check dimensions of the embedded image and whether it could be loaded.
>   */
> +function check_image_size(aController, aImage, aID, aSrcStart) {

You pass no aID from the callers.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1360443.patch (v2b).

(In reply to :aceman from comment #5)
> You pass no aID from the callers.
Damn. However, the test passed ;-)

Comment 7

[:aceman]

Comment on attachment 8867508 [details] [diff] [review]
1360443.patch (v2b).

Review of attachment 8867508 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/test/mozmill/composition/test-image-display.js
@@ +31,5 @@
>  
>  /**
>   * Check dimensions of the embedded image and whether it could be loaded.
>   */
> +function check_image_size(aController, aImage, aID, aSrcStart) {

In the current set of tests, you could just use aImage.id . Or do you prepare this function for passing in elements without id? Even in that case showing no ID would be fine.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1360443.patch (v2c).

I should have let you do it ;-(

Comment 9

[:aceman]

Comment on attachment 8867510 [details] [diff] [review]
1360443.patch (v2c).

Review of attachment 8867510 [details] [diff] [review]:
-----------------------------------------------------------------

OK now :)

Comment 10

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/5b50c171efdcf955f31ad747ab444ca97df3c83b