1360658 - Snack bars not showing up in WebAppActivity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

We're in a subclass, so our BundleEventListener will override GeckoApp's listener. Therefore we need to forward all calls to it as well, otherwise random stuff handled by GeckoApp (e.g. snack bars) won't work.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1360658 - Forward BundleEvents from WebAppActivity to GeckoApp.

Otherwise random stuff handled by GeckoApp (e.g. snack bars) won't work inside a WebAppActivity.

Review commit: https://reviewboard.mozilla.org/r/134834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134834/

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 8862972 [details]
Bug 1360658 - Forward BundleEvents from WebAppActivity to GeckoApp.

https://reviewboard.mozilla.org/r/134834/#review138340

Yup I was wondering whether that was going to be needed, thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/632e25ba6de9
Forward BundleEvents from WebAppActivity to GeckoApp. r=daleharvey

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/632e25ba6de9

Comment 7

[Oana Horvath [:ohorvath - out of office]]

Verified that all snackbars appear in web apps, also verified the permission requests (bug 1355513) and Android 6+ text sharing (bug 1355847)are working.
-Lenovo A536 (Android 4.4.2)
-Motorola Nexus 6 (Android 7.0)
-HTC 10 (Android 6.0.1)