1360854 - Permaorange in browser_all_files_referenced.js when Gecko 55 merges to beta on 2017-06-12 caused by bug 1345122

Status: RESOLVED FIXED

(Firefox Graveyard :: Activity Streams: General, defect)

Description

[Phil Ringnalda (:philor)]

Looks like browser/components/newtab/NewTabMessages.jsm was keeping resource://app/modules/PreviewProvider.jsm referenced in non-nightly when activity-stream wasn't built, but bug 1345122 removed it, so when we merge to beta in June we're going to have permaorange like https://treeherder.mozilla.org/logviewer.html#?job_id=95481885&repo=try from it being unreferenced.

Comment 1

[Phil Ringnalda (:philor)]

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1.

Comment 2

[Ed Lee :Mardak]

To be clear, the issue is that activity-stream is only being built on nightly:
https://hg.mozilla.org/try/file/f0bcc04b08d47bb40680f919f267c1e8a5691088/browser/extensions/moz.build#l31

So even though it's being referenced:
https://hg.mozilla.org/try/file/f0bcc04b08d47bb40680f919f267c1e8a5691088/browser/extensions/activity-stream/lib/TopSitesFeed.jsm#l11

And I believe we do want PreviewProvider to be packaged in beta as we are using it from the test pilot activity-stream add-on.

So is the fix to whitelist that file in the test?
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/static/browser_all_files_referenced.js

Comment 3

[Marcia Knous [:marcia]]

Tracking 55+ for this permaorange.

Comment 4

[Ursula Sarracini (:ursula)]

Spoke with mconley and he suggested we add a filtering on channels to conditionally add PreviewProvider to the whitelist depending on the build we're running. So PreviewProvider.jsm will be added to the whitelist if we're not on Nightly

Comment 5

[Ed Lee :Mardak]

To test a fix, do we just set EARLY_BETA_OR_EARLIER=1 in build/defines.sh ?

Comment 6

[Phil Ringnalda (:philor)]

As long as the difference is from either NIGHTLY_BUILD or RELEASE_OR_BETA, just edit /config/milestone.txt and change the 55.0a1 to 55.0 - you only need to mess with EARLY_BETA if you have something keyed off it (in which case you would be changing it from the trunk-until-partway-through EARLY_BETA_OR_EARLIER=1 to EARLY_BETA_OR_EARLIER=).

Comment 7

[Ursula Sarracini (:ursula)]

Attachment: Bug 1360854 - Permaorange in browser_all_files_referenced.js caused by bug 1345122

Review commit: https://reviewboard.mozilla.org/r/135272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135272/

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8863496 [details]
Bug 1360854 - Permaorange in browser_all_files_referenced.js caused by bug 1345122

https://reviewboard.mozilla.org/r/135272/#review138614

::: browser/base/content/test/static/browser_all_files_referenced.js:83
(Diff revision 1)
>  
>    // browser/components/newtab bug 1355166
>    {file: "resource://app/modules/NewTabSearchProvider.jsm"},
>    {file: "resource://app/modules/NewTabWebChannel.jsm"},
>  
> +  // bug 1360854

Please include a one-line description of why we are intentionally shipping this unreferenced file.

The other 'bug <number>' exceptions are for files that should just be removed as soon as someone takes the referenced bug.

Comment 9

[Ursula Sarracini (:ursula)]

Comment on attachment 8863496 [details]
Bug 1360854 - Permaorange in browser_all_files_referenced.js caused by bug 1345122

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135272/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e15da285b2
Permaorange in browser_all_files_referenced.js caused by bug 1345122 r=florian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50e15da285b2