1361000 - Add deprecation warning for removing support for EME on insecure contexts

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In bug 1322517 we will remove support for EME in insecure contexts. We should add a warning when EME is used in insecure contexts, so authors have time to transition.

We have 1 day of data on the telemetry probe I added to determine what proportion of contexts where EME is used are insecure, and it's showing 15% of contexts are insecure.

https://mzl.la/2oWGeWs

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1361000 - Log a deprecation warning to the web console upon use of EME in an insecure context.

Preliminary telemetry indicated 15% of users of EME are in an insecure
context. We'd better log a warning to the web console to inform authors
that their sites will stop working, rather than just breaking them!

Review commit: https://reviewboard.mozilla.org/r/135100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135100/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8863306 [details]
Bug 1361000 - Log a deprecation warning to the web console upon use of EME in an insecure context.

https://reviewboard.mozilla.org/r/135100/#review138128

Does the console show which url (of the page, that is) is involved?   If not, please include it in the warning.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8863306 [details]
Bug 1361000 - Log a deprecation warning to the web console upon use of EME in an insecure context.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135100/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c733f9dbec85
Log a deprecation warning to the web console upon use of EME in an insecure context. r=bz

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/a812a96caba2 - built nicely on Windows, but everything else failed like https://treeherder.mozilla.org/logviewer.html#?job_id=95817339&repo=autoland, "Navigator.cpp:2032:31: error: ignoring return value of 'nsresult nsIDocument::GetDocumentURI(nsString&) const', declared with attribute warn_unused_result [-Werror=unused-result]"

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8863306 [details]
Bug 1361000 - Log a deprecation warning to the web console upon use of EME in an insecure context.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135100/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1242d70ee6a2
Log a deprecation warning to the web console upon use of EME in an insecure context. r=bz

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1242d70ee6a2

Comment 9

[Kohei Yoshino]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/support-for-eme-on-insecure-contexts-has-been-deprecated/

Comment 10

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en-US/docs/Web/API/Encrypted_Media_Extensions_API
https://developer.mozilla.org/en-US/Firefox/Releases/55