1322517 - [EME] Remove support for EME on insecure contexts

Status: NEW

(Core :: Audio/Video: Playback, task, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The EME spec says it is only to be supported on secure contexts.

Netflix are already only using EME over HTTPS in Firefox.

Our intention is to make this change the Firefox release after Chrome ships this.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Chrome's Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXmKPlXsnCQ

Bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=672605

Status:
https://www.chromestatus.com/feature/5724389932793856

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Remove support for EME on insecure contexts

MozReview-Commit-ID: 1kIWXRS7BJu

Comment 3

[James Cheng[:JamesCheng]]

Chrome has removed support for EME on insecure contexts in their 58 (https://www.chromestatus.com/features/5724389932793856)

I will take over this bug and move on dom peer reviewing.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Telemetry shows that 10.92% of all EME content is served on non-secure contexts in Firefox 56 release: https://mzl.la/2h0hbUF

The telemetry has expired too, we should really renew it.

Comment 5

[James Cheng[:JamesCheng]]

If I extend the telemetry, should I still need to work on this bug to remove supporting on insecure context? 

Thanks.

Comment 6

[James Cheng[:JamesCheng]]

The MEDIA_EME_SECURE_CONTEXT will be expired in gecko 60.

http://searchfox.org/mozilla-central/rev/aa1343961fca52e8c7dab16788530da31aab7c8d/toolkit/components/telemetry/Histograms.json#8569

So we will extend the telemetry when Nightly hits ver.60 (2018-01-15). I will extend the telemetry to 63.

Telemetry shows that 10.92% of all EME content is served on non-secure contexts in Firefox 56.

We expect the number eliminates to around 2% then I will move on this bug.

Comment 7

[James Cheng[:JamesCheng]]

Attachment: Bug 1322517 - Part 1 - Remove support for EME on insecure contexts.

Review commit: https://reviewboard.mozilla.org/r/196234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196234/

Comment 8

[James Cheng[:JamesCheng]]

There is a lot of test failures 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e095734e1666d0384b4dfa12a7c7459077c94a28&selectedJob=144854157

I think we should use

https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/dom/tests/mochitest/general/test_interfaces.js#874

to mark them test in SecureContext.

I will provide a patch in this bug to fix those error together when I need to go back working on this.

Comment 9

[James Cheng[:JamesCheng]]

Part1 only
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e095734e1666d0384b4dfa12a7c7459077c94a28

Part1 + Part2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dbae00b120122019ed5a0e5ba8173de64f0a75d

So we need part2 once we want to land part1.

Comment 10

[James Cheng[:JamesCheng]]

Attachment: Bug 1322517 - Part 2 - Mark those MediaKey API securecontext in test_interfaces.html

Review commit: https://reviewboard.mozilla.org/r/199698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199698/

Comment 11

[James Cheng[:JamesCheng]]

Comment on attachment 8924978 [details]
Bug 1322517 - Part 1 - Remove support for EME on insecure contexts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196234/diff/1-2/

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 26

[Daniel Veditz [:dveditz]]

restricting comments due to spam