Closed Bug 1361175 Opened 8 years ago Closed 8 years ago

Remove wow{{ funnelcake_id }} from the first run templates used for onboarding experiments

Categories

(www.mozilla.org :: Pages & Content, enhancement)

Production
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cmore, Assigned: jpetto)

References

Details

Attachments

(1 file)

44 bytes, text/x-github-pull-request
Details | Review
In bug 1354710, the moz.org team made funnelcake parameters automatically pass through to fxa via the utm_source parameter. This worked as planned, but some html templates override the FxA iframe source. It was also made in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1354710#c7 "Small correction, please do not change the entrypoint. This should remain firstrun (without anything appended to it). The goal of using utm_source is to not touch the entrypoint." The HTML template below that was used for funnelcake 98, 99 and 100 are being used again for funnelcakes 111, 112, and 113 via bug 1348126 seen below: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/firstrun/new-firstrun.html#L33 These templates also modify the fxa iframe src and also modifies the entrypoint as in "entrypoint=firstrunwow{{ funnelcake_id }}" As mentioned above, we cannot be modifying the entrypoint value as it is skewing the FxA results which rely on this value staying consistent over time. The entrypoint was modified before, because the Firefox UX team wanted to segment the FxA data by each of the funnelcakes and they just picked the entrypoint parameter, but any of the other parameters could have worked too. Let's not do that again and use the utm_source now and going forward. Please change entrypoint=firstrunwow{{ funnelcake_id }} to entrypoint=firstrun in the HTML template.
Blocks: 1348129
Assignee: nobody → jon
Oh! Good catch!
Attached file GitHub PR
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/4882d2df327945df3d877c4bdea1b770bc1d3346 [fix bug 1361175] Remove custom entrypoint param from firstrun template https://github.com/mozilla/bedrock/commit/a891701465ef3a3ea125b27d60852747664a0ea7 Merge pull request #4797 from jpetto/bug-1361175-update-fxa-iframe-params-on-firstrun-variant [fix bug 1361175] Remove custom entrypoint param from firstrun template
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: