1361257 - Don't synchronously flush rendering on Windows

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

On my Desktop at home, I noticed that we block window opening for about 50ms while waiting for a texture upload in the compositor. On the Quantum Reference machine it's closer to 200ms.

We added this synchronous call in bug 873944 to deal with resize issues on Mac. However my understanding is that paints on Windows are asynchronous - the DWM doesn't really care about what happens in WM_PAINT. So we can probably make this call asynchronous on Windows. I don't see any change in resize behavior either way.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Add PCompositorBridge::FlushRenderingAsync so we can bypass the synchronous path on Windows.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8863598 [details] [diff] [review]
fix

Review of attachment 8863598 [details] [diff] [review]:
-----------------------------------------------------------------

Please make a pref to override this, I suspect there are configurations in which this will lead to artifacts.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc797baedf3
Don't synchronously composite when resizing widgets on Windows. (bug 1361257, r=bas)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9bc797baedf3