Closed Bug 1361257 Opened 4 years ago Closed 4 years ago

Don't synchronously flush rendering on Windows

Categories

(Core :: Graphics: Layers, enhancement)

Product:
Core
Component:
Graphics: Layers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Depends on 1 open bug)

Details

(Whiteboard: [qf:p3])

Attachments

(1 file)

fix
8.08 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
On my Desktop at home, I noticed that we block window opening for about 50ms while waiting for a texture upload in the compositor. On the Quantum Reference machine it's closer to 200ms.

We added this synchronous call in bug 873944 to deal with resize issues on Mac. However my understanding is that paints on Windows are asynchronous - the DWM doesn't really care about what happens in WM_PAINT. So we can probably make this call asynchronous on Windows. I don't see any change in resize behavior either way.
Attached patch fix — — Splinter Review 
Add PCompositorBridge::FlushRenderingAsync so we can bypass the synchronous path on Windows.
Attachment #8863598 - Flags: review?(bas)
Comment on attachment 8863598 [details] [diff] [review]
fix

Review of attachment 8863598 [details] [diff] [review]:
-----------------------------------------------------------------

Please make a pref to override this, I suspect there are configurations in which this will lead to artifacts.
Attachment #8863598 - Flags: review?(bas) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc797baedf3
Don't synchronously composite when resizing widgets on Windows. (bug 1361257, r=bas)
Whiteboard: [qf:p3]
https://hg.mozilla.org/mozilla-central/rev/9bc797baedf3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1363122
See Also: → 1363958
Depends on: 1380462
You need to log in before you can comment on or make changes to this bug.