1363122 - Widgets are not correctly drawn in Windows Classic theme since asynchronous flush rendering has been enabled

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ziga Seilnacht]

Since bug 1361257 landed, the native widgets (main Firefox window menus, right click menus, <select> drop downs, ...) don't get drawn for me anymore. I'm using Windows 7's "Windows Classic" theme (which disables desktop composition), which could be why others aren't seeing this problem.

If I set the "layers.force-synchronous-resize" preference to true, the problem disappears.

Excerpt from about:support, in case it is relevant:

Application Basics
------------------

Name: Firefox
Version: 55.0a1
Build ID: 20170508030204
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
OS: Windows_NT 6.1
Multiprocess Windows: 1/1 (Enabled by default)

Graphics
--------

Features
Compositing: Direct3D 11
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled
Audio Backend: wasapi
Direct2D: true
DirectWrite: true (6.2.9200.22082)
GPU #1
Active: Yes
Description: AMD FirePro M4000
Vendor ID: 0x1002
Device ID: 0x682d
Driver Version: 21.19.169.768
Driver Date: 3-8-2017
Drivers: aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64
Subsys ID: 176c103c
RAM: 1024

Diagnostics
AzureCanvasAccelerated: 0
AzureCanvasBackend: Direct2D 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: Direct2D 1.1
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): cairo
GPUProcessPid: 6044
GPUProcess: Terminate GPU Process
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Good catch, thanks for narrowing this down!

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e916525919a9
Revert to synchronous resizes when the DWM is disabled. (bug 1363122, r=bas)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e916525919a9