1361589 - Coverity report: nsMathMLmencloseFrame::mRuleThickness/mRadicalRuleThickness is not initialized in this constructor nor in any functions that it calls

Status: RESOLVED FIXED

(Core :: MathML, defect, P4)

Description

[Mats Palmgren (inactive)]

Coverity CID 750310 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.

In nsMathMLmencloseFrame::​nsMathMLmencloseFrame(nsStyleContext *): A scalar field is not initialized by the constructor


 50nsMathMLmencloseFrame::nsMathMLmencloseFrame(nsStyleContext* aContext) :
 51  nsMathMLContainerFrame(aContext), mNotationsToDraw(0),
 52  mLongDivCharIndex(-1), mRadicalCharIndex(-1), mContentWidth(0)
 53{
   2. uninit_member: Non-static class member mRuleThickness is not initialized in this constructor nor in any functions that it calls.
   CID 750310 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)4. uninit_member: Non-static class member mRadicalRuleThickness is not initialized in this constructor nor in any functions that it calls.
 54}

Comment 1

[Mats Palmgren (inactive)]

It looks like we initialize these during reflow and then use them during paint
so it's probably OK.  I think we should initialize them to zero in the ctor anyway.

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Patch

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8865114 [details] [diff] [review]
Patch

See https://bugzilla.mozilla.org/show_bug.cgi?id=1361647#c2
and https://bugzilla.mozilla.org/show_bug.cgi?id=1361591#c3

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc5f257ad83b
Coverity report: nsMathMLmencloseFrame::mRuleThickness/mRadicalRuleThickness is not initialized in this constructor nor in any functions that it calls. r=karlt

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc5f257ad83b