1361718 - The toggle-sidebar button should preserve open / closed state when rows are clicked.

Status: NEW

(DevTools :: Netmonitor, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The UX is different between the toggle-sidebar button in the Network Monitor and the Storage Inspector.

In the Network Monitor, if you close the sidebar, the selected entry gets deselected and so the sidebar gets opened again once you select another entry.

In the Storage and DOM Inspectors if you click the sidebar toggle button to close the sidebar you can select rows without the sidebar interfering. The sidebar reappears only if the sidebar toggle button is clicked again.

We should change the Network Monitor so that it matches the Storage and DOM Inspectors.

Comment 3

[Mrigank Krishan]

Hey, I'd like to work on this.
Is it a good idea to place the toggle button in the Toolbar? like https://i.imgur.com/K4KajHP.png

I think it should on the same level as the Hide Details button but it'd be troublesome because of the request list table.

How about we don't add a separate button, clicking on a selected request will open network details automatically?
Any suggestions?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Mike: what do you refer to by "DOM Inspectors"?

@Harald: I like this suggestion, is that ok with you?

Honza

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

@Mike: what do you refer to by "DOM Inspectors"?

To be honest I have no idea what I meant by the "DOM Inspectors."

We used this behaviour in the storage panel because users were complaining that it was difficult to edit values if the sidebar opens every time they try to edit something.

This also matches the behaviour in the debugger where you can hide the sidebar and it stays hidden until you show it again.

Comment 6

[:Harald Kirschner :digitarald]

What we have now matches behavior of other devtools (apart from the icon, which re-uses the overloaded sidebar toggle icon) – so based on UX consistency I would argue to keep the current toggle behavior if we don't come up with some good reasons.

We used this behaviour in the storage panel because users were complaining that it was difficult to edit values if the sidebar opens every time they try to edit something.

Network panel does not have editing, so what would be the user pain that this solves?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to :Harald Kirschner :digitarald from comment #6)

What we have now matches behavior of other devtools (apart from the icon, which re-uses the overloaded sidebar toggle icon) – so based on UX consistency I would argue to keep the current toggle behavior if we don't come up with some good reasons.

Agreed

I vote for changing one thing - avoid opening the side bar (i.e. selection) by right-click.
Covered by: bug 1466598

Otherwise, I think we can close this one.

Honza