1361751 - Update webrender to 964df2fa00f330daf4f233669e37133f93113792

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1359744 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 964df2fa00f330daf4f233669e37133f93113792

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ed19de0514c84856c83a046170aa46250ef8b94

Busted. Regression range is:

* 964df2f Auto merge of #1181 - Gankro:bincode-ipc-5, r=kvark
* ff8f8db fix examples
* d4c3270 New webrender IPC - wrench fallout
* 35de574 New bincode-based IPC model

Therefore the bustage is from from servo/webrender#1181 - as Gankro predicted. He said he's working on it, so I'll wait for a patch from him.

Comment 3

[Aria Beingessner [:Gankra]]

Attachment: Bug 1361751 - update gecko bindings to webrender to reflect changes

Review commit: https://reviewboard.mozilla.org/r/137292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137292/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8865662 [details]
Bug 1361751 - update gecko bindings to webrender to reflect changes

https://reviewboard.mozilla.org/r/137292/#review140334

This patch should include the updated webrender_ffi_generated.h file as well.

::: commit-message-f18b8:1
(Diff revision 1)
> +Bug 1361751 - update gecko bindings to webrender to reflect changes r=kats

Include either the webrender PR number or a webrender hash so that it's clearer which changes this is reflecting.

::: toolkit/library/gtest/rust/Cargo.lock:1064
(Diff revision 1)
>  [[package]]
>  name = "webrender_traits"
>  version = "0.36.0"
>  dependencies = [
>   "app_units 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
> + "bincode 1.0.0-alpha6 (registry+https://github.com/rust-lang/crates.io-index)",

Where are these Cargo.lock changes coming from? This patch doesn't touch any Cargo.toml files so the Cargo.lock changes shouldn't be here either.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8865662 [details]
Bug 1361751 - update gecko bindings to webrender to reflect changes

https://reviewboard.mozilla.org/r/137292/#review140624

I put together a full WR update patchset using this patch. Try push is going at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b27031835f77db93faf5dd35456e9b0970d1b395

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Try push is showing reftest failures, so we'll need to figure that out before we can land the update.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=faa56b8159c9f914f7b2301f378765e5450ea28c is green

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361751 - Update webrender to 964df2f.

Review commit: https://reviewboard.mozilla.org/r/137912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137912/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361751 - Update Cargo.lock files and regenerate bindings.

Review commit: https://reviewboard.mozilla.org/r/137914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137914/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361751 - Update gecko bindings to webrender to reflect changes in PR 1181.

Review commit: https://reviewboard.mozilla.org/r/137916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137916/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8866297 [details]
Bug 1361751 - Update gecko bindings to webrender to reflect changes in PR 1181.

https://reviewboard.mozilla.org/r/137916/#review141026

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8866296 [details]
Bug 1361751 - Update Cargo.lock files and regenerate bindings.

https://reviewboard.mozilla.org/r/137914/#review141096

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8866295 [details]
Bug 1361751 - Update webrender to 964df2f.

https://reviewboard.mozilla.org/r/137912/#review141098

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9d9046d172d6
Update webrender to 964df2f. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/b84bdb44e96b
Update gecko bindings to webrender to reflect changes in PR 1181. r=kats

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d9046d172d6
https://hg.mozilla.org/mozilla-central/rev/b84bdb44e96b