Update webrender to 964df2fa00f330daf4f233669e37133f93113792

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1359744 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 964df2fa00f330daf4f233669e37133f93113792

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ed19de0514c84856c83a046170aa46250ef8b94

Busted. Regression range is:

* 964df2f Auto merge of #1181 - Gankro:bincode-ipc-5, r=kvark
* ff8f8db fix examples
* d4c3270 New webrender IPC - wrench fallout
* 35de574 New bincode-based IPC model

Therefore the bustage is from from servo/webrender#1181 - as Gankro predicted. He said he's working on it, so I'll wait for a patch from him.
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1362905
Comment hidden (mozreview-request)
(Assignee)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8865662 [details]
Bug 1361751 - update gecko bindings to webrender to reflect changes

https://reviewboard.mozilla.org/r/137292/#review140334

This patch should include the updated webrender_ffi_generated.h file as well.

::: commit-message-f18b8:1
(Diff revision 1)
> +Bug 1361751 - update gecko bindings to webrender to reflect changes r=kats

Include either the webrender PR number or a webrender hash so that it's clearer which changes this is reflecting.

::: toolkit/library/gtest/rust/Cargo.lock:1064
(Diff revision 1)
>  [[package]]
>  name = "webrender_traits"
>  version = "0.36.0"
>  dependencies = [
>   "app_units 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
> + "bincode 1.0.0-alpha6 (registry+https://github.com/rust-lang/crates.io-index)",

Where are these Cargo.lock changes coming from? This patch doesn't touch any Cargo.toml files so the Cargo.lock changes shouldn't be here either.
(Assignee)

Updated

7 months ago
Depends on: 1363201
(Assignee)

Comment 5

7 months ago
mozreview-review
Comment on attachment 8865662 [details]
Bug 1361751 - update gecko bindings to webrender to reflect changes

https://reviewboard.mozilla.org/r/137292/#review140624

I put together a full WR update patchset using this patch. Try push is going at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b27031835f77db93faf5dd35456e9b0970d1b395
Attachment #8865662 - Flags: review?(bugmail) → review+
Try push is showing reftest failures, so we'll need to figure that out before we can land the update.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=faa56b8159c9f914f7b2301f378765e5450ea28c is green
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8865662 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 964df2fa00f330daf4f233669e37133f93113792
(Assignee)

Comment 11

7 months ago
mozreview-review
Comment on attachment 8866297 [details]
Bug 1361751 - Update gecko bindings to webrender to reflect changes in PR 1181.

https://reviewboard.mozilla.org/r/137916/#review141026
Attachment #8866297 - Flags: review?(bugmail) → review+

Comment 12

7 months ago
mozreview-review
Comment on attachment 8866296 [details]
Bug 1361751 - Update Cargo.lock files and regenerate bindings.

https://reviewboard.mozilla.org/r/137914/#review141096
Attachment #8866296 - Flags: review?(jmuizelaar) → review+

Comment 13

7 months ago
mozreview-review
Comment on attachment 8866295 [details]
Bug 1361751 - Update webrender to 964df2f.

https://reviewboard.mozilla.org/r/137912/#review141098
Attachment #8866295 - Flags: review?(jmuizelaar) → review+

Comment 14

7 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9d9046d172d6
Update webrender to 964df2f. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/b84bdb44e96b
Update gecko bindings to webrender to reflect changes in PR 1181. r=kats
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED

Comment 15

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d9046d172d6
https://hg.mozilla.org/mozilla-central/rev/b84bdb44e96b
(Assignee)

Updated

7 months ago
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.