1363201 - WrVecU8 is misimplemented

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Aria Beingessner [:Gankra]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

length isn't initialized in the constructors

Comment 1

[Aria Beingessner [:Gankra]]

Attachment: Bug 1363201 - fix the impl of WrVecU8,

Review commit: https://reviewboard.mozilla.org/r/137280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137280/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

https://reviewboard.mozilla.org/r/137280/#review140312

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

https://reviewboard.mozilla.org/r/137280/#review140336

::: commit-message-f18b8:1
(Diff revision 1)
> +Bug 1363201 - fix the impl of WrVecU8, r=jrmuizel

Please use a more descriptive commit message. It's not at all clear to me why you changed from nullptr to (uint8_t*)1, that should be explained somewhere.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It's, in fact, probably worth explaining (unint8_t*)1 in a comment.

Comment 5

[Aria Beingessner [:Gankra]]

Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137280/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81586e95c8f30aa6bcc0b6521cd731237dc636f includes this patch

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Try push is showing failures. I did another try push with just this patch (without the WR update) to confirm that the failures are from the WR update. If so we can land this patch safely.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a173efe50567e0930236b573d6c57039033b131c

Comment 8

[Aria Beingessner [:Gankra]]

Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137280/diff/2-3/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42f89dd25b638242938fd32029159c3618bdc2a3

Comment 10

[Kartikaya Gupta (email:[e-mail])]

That one is good. Landing...

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/c509185bf7e5
fix the impl of WrVecU8, r=jrmuizel

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c509185bf7e5