Closed Bug 1363201 Opened 3 years ago Closed 3 years ago

WrVecU8 is misimplemented

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Gankra, Assigned: Gankra)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

length isn't initialized in the constructors
Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

https://reviewboard.mozilla.org/r/137280/#review140312
Attachment #8865659 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8865659 [details]
Bug 1363201 - fix the impl of WrVecU8,

https://reviewboard.mozilla.org/r/137280/#review140336

::: commit-message-f18b8:1
(Diff revision 1)
> +Bug 1363201 - fix the impl of WrVecU8, r=jrmuizel

Please use a more descriptive commit message. It's not at all clear to me why you changed from nullptr to (uint8_t*)1, that should be explained somewhere.
It's, in fact, probably worth explaining (unint8_t*)1 in a comment.
Assignee: nobody → a.beingessner
Status: UNCONFIRMED → NEW
Ever confirmed: true
Try push is showing failures. I did another try push with just this patch (without the WR update) to confirm that the failures are from the WR update. If so we can land this patch safely.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a173efe50567e0930236b573d6c57039033b131c
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/c509185bf7e5
fix the impl of WrVecU8, r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.