1361760 - Enable ESLint recommended rules for dom/indexedDB/test/unit

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement)

Description

[Mark Banner (:standard8)]

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

dom/indexedDB is run for ESLint, but has very few rules enabled, hence this bug will work on enabling at least some of those rules.

The advantages here are fast development for developers - as some obvious mistakes will be highlighted quickly, and it'll also help shorten review times by having a standard automatically applied.

Comment 1

[Mark Banner (:standard8)]

Switching this to be just about dom/indexedDB/test/unit due to size of patches. I'll file a follow-up for dom/indexedDB/test.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit.

Review commit: https://reviewboard.mozilla.org/r/137664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137664/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes.

Review commit: https://reviewboard.mozilla.org/r/137666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137666/

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes.

Review commit: https://reviewboard.mozilla.org/r/137668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137668/

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8866070 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit.

https://reviewboard.mozilla.org/r/137664/#review143936

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8866071 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes.

https://reviewboard.mozilla.org/r/137666/#review143938

r=me after the intent is fixed, thanks!

::: dom/indexedDB/test/unit/test_defaultStorageUpgrade.js:103
(Diff revision 1)
>          request = indexedDB.open(params.dbName, params.dbVersion);
>        } else {
>          request = indexedDB.open(params.dbName, params.dbOptions);
>        }

Decrease intent for these lines.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8866071 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes.

https://reviewboard.mozilla.org/r/137666/#review143944

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8866072 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes.

https://reviewboard.mozilla.org/r/137668/#review143948

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8866070 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137664/diff/1-2/

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8866071 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137666/diff/1-2/

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8866072 [details]
Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137668/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/261943b7c364
Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit. r=bevis
https://hg.mozilla.org/integration/autoland/rev/f261aca8246b
Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes. r=bevis
https://hg.mozilla.org/integration/autoland/rev/97a22f66e322
Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes. r=bevis

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/261943b7c364
https://hg.mozilla.org/mozilla-central/rev/f261aca8246b
https://hg.mozilla.org/mozilla-central/rev/97a22f66e322