Closed
Bug 1361760
Opened 7 years ago
Closed 7 years ago
Enable ESLint recommended rules for dom/indexedDB/test/unit
Categories
(Core :: Storage: IndexedDB, enhancement)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely. dom/indexedDB is run for ESLint, but has very few rules enabled, hence this bug will work on enabling at least some of those rules. The advantages here are fast development for developers - as some obvious mistakes will be highlighted quickly, and it'll also help shorten review times by having a standard automatically applied.
Assignee | ||
Comment 1•7 years ago
|
||
Switching this to be just about dom/indexedDB/test/unit due to size of patches. I'll file a follow-up for dom/indexedDB/test.
Summary: Enable ESLint recommended rules for dom/indexedDB → Enable ESLint recommended rules for dom/indexedDB/test/unit
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8866070 -
Flags: review?(jvarga) → review?(btseng)
Attachment #8866071 -
Flags: review?(jvarga) → review?(btseng)
Attachment #8866072 -
Flags: review?(jvarga) → review?(btseng)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8866070 [details] Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit. https://reviewboard.mozilla.org/r/137664/#review143936
Attachment #8866070 -
Flags: review?(btseng) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8866071 [details] Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes. https://reviewboard.mozilla.org/r/137666/#review143938 r=me after the intent is fixed, thanks! ::: dom/indexedDB/test/unit/test_defaultStorageUpgrade.js:103 (Diff revision 1) > request = indexedDB.open(params.dbName, params.dbVersion); > } else { > request = indexedDB.open(params.dbName, params.dbOptions); > } Decrease intent for these lines.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8866071 [details] Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes. https://reviewboard.mozilla.org/r/137666/#review143944
Attachment #8866071 -
Flags: review?(btseng) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8866072 [details] Bug 1361760 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes. https://reviewboard.mozilla.org/r/137668/#review143948
Attachment #8866072 -
Flags: review?(btseng) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/261943b7c364 Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit. r=bevis https://hg.mozilla.org/integration/autoland/rev/f261aca8246b Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - automatic fixes. r=bevis https://hg.mozilla.org/integration/autoland/rev/97a22f66e322 Enable some Mozilla ESLint recommended rules for dom/indexedDB/test/unit - manual fixes. r=bevis
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/261943b7c364 https://hg.mozilla.org/mozilla-central/rev/f261aca8246b https://hg.mozilla.org/mozilla-central/rev/97a22f66e322
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•