Closed
Bug 1363795
Opened 4 years ago
Closed 4 years ago
Enable ESLint recommended rules for dom/indexedDB/test/
Categories
(Core :: Storage: IndexedDB, enhancement)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(3 files)
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely. dom/indexedDB/test is run for ESLint, but has very few rules enabled, hence this bug will work on enabling at least some of those rules. The advantages here are fast development for developers - as some obvious mistakes will be highlighted quickly, and it'll also help shorten review times by having a standard automatically applied.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8868985 [details] Bug 1363795 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test (no-undef). https://reviewboard.mozilla.org/r/140664/#review144426
Attachment #8868985 -
Flags: review?(btseng) → review+
|
|
||
Comment 5•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8868986 [details] Bug 1363795 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test - automatic fixes. https://reviewboard.mozilla.org/r/140666/#review144428
Attachment #8868986 -
Flags: review?(btseng) → review+
|
|
||
Comment 6•4 years ago
|
||
| mozreview-review | ||
Comment on attachment 8868987 [details] Bug 1363795 - Enable some Mozilla ESLint recommended rules for dom/indexedDB/test - manual fixes. https://reviewboard.mozilla.org/r/140668/#review144430 Thanks!
Attachment #8868987 -
Flags: review?(btseng) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be00938a6852 Enable some Mozilla ESLint recommended rules for dom/indexedDB/test (no-undef). r=bevis https://hg.mozilla.org/integration/autoland/rev/ab9b62e22a5d Enable some Mozilla ESLint recommended rules for dom/indexedDB/test - automatic fixes. r=bevis https://hg.mozilla.org/integration/autoland/rev/de859ae64421 Enable some Mozilla ESLint recommended rules for dom/indexedDB/test - manual fixes. r=bevis
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/be00938a6852 https://hg.mozilla.org/mozilla-central/rev/ab9b62e22a5d https://hg.mozilla.org/mozilla-central/rev/de859ae64421
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•