1361798 - Configure Nightly to download and use the 3rd-party flash blocklist (set plugins.flashBlock.enabled=true)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1317856 +++

Switching plugins.flashBlock.enabled got non-trivial, so instead of mixing that on bug 1317856, I'm spinning this off to this separate bug in order to make things clearer. 

Note that this also has the side-effect that now we'll start blocking Flash on null and system principals.

In order to land this, we need:

- Switch the pref (patch reviewed by bsmedberg on 1317856)
- Fix the reftest harness code that checks if the Test plug-in exists
- Move tests that uses the Test plug-in in chrome/data:, to non-chrome/http (these are fixed on bug 1335475 and I'll be cherry-picking them to land)

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Set plugins.flashBlock.enabled=true on Nightly, r=bsmedberg

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Update reftest harness code

Previously the harness would check for navigator.plugins[Test Plug-in] in the browser window, but that is now blocked from working. Instead we can simply use an existing getTestPlugin function that enumerates the plugin through nsIPluginHost

Comment 3

[Benjamin Smedberg]

See https://reviewboard.mozilla.org/r/118608/diff/5/

This patch is already reviewed, but IIRC it's also the patch that broke stylo reftests. If that works now feel free to land it.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Ah, I missed that there.. I sent this to try, let's see how it goes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c04310e6fb695e396055084c53dd8135445c6d65

Comment 5

[:Felipe Gomes (needinfo for replies!)]

The stylo tests worked:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19ff162c738922a6bc9bcf3ae11d57f07da86293

Maybe your bug can land, after all? Or maybe what was crashing was the HTTP changes, which I didn't include to not be blocked on that. But it's a bit bitrotted anyways, so I'll not include it fully now, only the cherry-picked parts that I need to land.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8864262 [details] [diff] [review]
Update reftest harness code

(same patch was written by bsmedberg and reviewed by dbaron. I kept the original attribution to land)

Comment 7

[Benjamin Smedberg]

roger go ahead and I'll de-bitrot my bits

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a12ce01a8b21
Configure Nightly to download and use the flash 3rd party blocklist, in preparation for switching Flash as Click-to-Activate. r=bsmedberg

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/a12ce01a8b21

Comment 10

[Chris Mills [:cmills]]

Hi. I just wanted to check what dev documentation updates you wanted as a result of this bug? We don't keep a record of Fx prefs on MDN (at least not anymore), and we archived our Flash docs some time ago.

Cheers!

Comment 11

[Benjamin Smedberg]

We need to document the behavior and rules of the 3rd-party Flash blocklist so that web developers know what to expect. I might be the best person to write that doc.